Notification spammed for calendar event #4811

provokateurin · 2022-12-08T07:50:28Z

Steps to reproduce

Run NC 24
Have a recurring calendar event like this:

BEGIN:VCALENDAR
CALSCALE:GREGORIAN
VERSION:2.0
PRODID:-//IDN nextcloud.com//Calendar app 3.5.0//EN
BEGIN:VEVENT
CREATED:20221010T152948Z
DTSTAMP:20221024T082910Z
LAST-MODIFIED:20221024T082910Z
SEQUENCE:3
UID:1a9d0c8a-f464-43f9-a907-912e8b2c0f7c
DTSTART;TZID=Europe/Berlin:20221011T190000
DTEND;TZID=Europe/Berlin:20221011T210000
STATUS:CONFIRMED
SUMMARY:pfadfinder
RRULE:FREQ=WEEKLY;BYDAY=TU
EXDATE;TZID=Europe/Berlin:20221025T190000
BEGIN:VALARM
ACTION:DISPLAY
TRIGGER;RELATED=START:-PT1H
END:VALARM
END:VEVENT
BEGIN:VTIMEZONE
TZID:Europe/Berlin
BEGIN:DAYLIGHT
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
TZNAME:CEST
DTSTART:19700329T020000
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
TZNAME:CET
DTSTART:19701025T030000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU
END:STANDARD
END:VTIMEZONE
END:VCALENDAR

Upgrade to NC 25
Get push notification spam for non-existent reminder

Expected behaviour

I should only get push notifications for the reminders i configured in the calendar event

Actual behaviour

I get a push notification every 10 minutes until the event. This starts one hour before the event starts, but that is also the only reminder I configured for the events.
This only happened with this one recurring event after the upgrade to NC 25, but I didn't update the event in any way.
I have another recurring calendar event that also existed before the upgrade, but I never got the push notification spam there until TODAY, so this is twice as annoying for me now. I did move it to a different day at some point, but I'm unsure if that was right before or after the upgrade.

Server configuration

Operating system: Docker alpine

Web server: nginx

Database: PostgreSQL

PHP version: 8.1

Nextcloud version: 25.0.1

Where did you install Nextcloud from: Docker/Helm Chart

Signing status:

No errors have been found.

List of activated apps:

Enabled:
  - activity: 2.17.0
  - calendar: 4.1.0
  - checksum: 1.2.0
  - circles: 25.0.0
  - cloud_federation_api: 1.8.0
  - collectives: 2.1.1
  - comments: 1.15.0
  - contacts: 5.0.1
  - contactsinteraction: 1.6.0
  - cookbook: 0.10.1
  - dashboard: 7.5.0
  - dav: 1.24.0
  - event_update_notification: 2.0.0
  - federatedfilesharing: 1.15.0
  - federation: 1.15.0
  - files: 1.20.1
  - files_pdfviewer: 2.6.0
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - firstrunwizard: 2.14.0
  - holiday_calendars: 0.2.1
  - logreader: 2.10.0
  - lookup_server_connector: 1.13.0
  - news: 19.0.0
  - nextcloud_announcements: 1.14.0
  - notes: 4.6.0
  - notifications: 2.13.1
  - oauth2: 1.13.0
  - password_policy: 1.15.0
  - photos: 2.0.0
  - privacy: 1.9.0
  - provisioning_api: 1.15.0
  - recommendations: 1.4.0
  - related_resources: 1.0.3
  - serverinfo: 1.15.0
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - support: 1.8.0
  - survey_client: 1.13.0
  - systemtags: 1.15.0
  - tasks: 0.14.5
  - text: 3.6.0
  - theming: 2.0.1
  - twofactor_backupcodes: 1.14.0
  - twofactor_totp: 7.0.0
  - twofactor_webauthn: 1.0.0
  - updatenotification: 1.15.0
  - user_status: 1.5.0
  - viewer: 1.9.0
  - weather_status: 1.5.0
  - workflowengine: 2.7.0
Disabled:
  - admin_audit
  - bruteforcesettings: 2.3.0
  - encryption
  - extract: 1.3.5
  - files_external: 1.15.0
  - suspicious_login
  - user_ldap

Nextcloud configuration:

{
    "system": {
        "htaccess.RewriteBase": "\/",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": "6379",
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "cloud.provokateurin.de"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "version": "25.0.1.1",
        "overwrite.cli.url": "https:\/\/cloud.provokateurin.de",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "overwriteprotocol": "https",
        "maintenance": false,
        "theme": "",
        "loglevel": 2
    }
}

Are you using an external user-backend, if yes which one: None

The text was updated successfully, but these errors were encountered:

provokateurin · 2022-12-08T07:57:28Z

The other calendar event I'm getting spammed for now:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:DAVx5/4.2.4-ose ical4j/3.2.5
BEGIN:VEVENT
DTSTAMP:20221124T091151Z
UID:bbbc0d5d-335a-49e5-a9f3-79affe26577c
SEQUENCE:1
SUMMARY:[REDACTED]
DTSTART;TZID=Europe/Berlin:20221124T091500
DTEND;TZID=Europe/Berlin:20221124T101500
RRULE:FREQ=WEEKLY;WKST=MO;BYDAY=TH
EXDATE;TZID=Europe/Berlin:20221201T091500
CLASS:PUBLIC
STATUS:CONFIRMED
BEGIN:VALARM
TRIGGER:-PT1H
ACTION:DISPLAY
DESCRIPTION:höllermann
END:VALARM
END:VEVENT
BEGIN:VTIMEZONE
TZID:Europe/Berlin
LAST-MODIFIED:20220816T024022Z
BEGIN:DAYLIGHT
TZNAME:CEST
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
DTSTART:19810329T020000
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU
END:DAYLIGHT
BEGIN:STANDARD
TZNAME:CET
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
DTSTART:19961027T030000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU
END:STANDARD
END:VTIMEZONE
END:VCALENDAR

nickvergessen · 2022-12-08T08:06:18Z

Do you have a screenshot of the notification, so I can see which part to look into?
Because the notification app does not at all know anything about reminders etc.

provokateurin · 2022-12-08T09:15:09Z

I'd have to wait for that until next Tuesday, but it's just the normal reminder push notification. There is no new notification, only the new push notification.

provokateurin · 2022-12-15T07:46:50Z

I noticed it's not only push notifications, but it's real notifications every 5 minutes between the reminder and the event. I think something with the cronjob is going wrong there. I guess this should be moved to the calendar repo?

provokateurin · 2022-12-15T07:48:43Z

No wait, for the other event it's every 10 minutes?! Still has to be something with calendar.

nickvergessen · 2022-12-15T07:55:17Z

That part actually lives in server.
Is it our instance c.nc.c?
If it's another instance, do you know if there is something in the log file?

provokateurin · 2022-12-15T09:13:23Z

It's my personal instance and I checked the logs and there is nothing :/

miaulalala · 2023-01-02T09:22:01Z

Looks like the VALARM isn't parsed correctly any longer. cc @st3iny

st3iny · 2023-01-02T09:53:28Z

Looks like the VALARM isn't parsed correctly any longer. cc @st3iny

Related to nextcloud/server#34909? (I really hope it isn't 🤞)

aledef · 2023-01-02T10:13:45Z

+1

miaulalala · 2023-01-02T15:49:32Z

We have some logging. @provokateurin can you please enable debug logging for your instance and look for reminders to process? I would like to know if the number of reminders decreases or stays relatively the same.

\Sabre\VObject\Component\VAlarm::getEffectiveTriggerTime is where VALARMS are parsed.
\OCA\DAV\CalDAV\Reminder\ReminderService::getRemindersForVAlarm another one that could be the culprit. I don't have time to investigate yet but will put this on my to do.

provokateurin · 2023-01-02T19:54:13Z

Sure, I should have the logs tomorrow evening when it happens again.

st3iny · 2023-01-03T09:36:06Z

@provokateurin Are you using a 32bit system/docker image by any chance?

provokateurin · 2023-01-03T09:36:49Z

Nope 64 bit

provokateurin · 2023-01-03T20:20:31Z

Hey @miaulalala I got the logs:

{"reqId":"2AKRsaXwdvuZszoBVqhE","level":0,"time":"2023-01-03T15:00:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"7DHuFnlDssQVIf6XuT6S","level":0,"time":"2023-01-03T15:10:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"gLghs0zwJJTLP9Utx8hu","level":0,"time":"2023-01-03T15:20:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"5Kglax4AwoUmLcqq79Ub","level":0,"time":"2023-01-03T15:30:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"b1YY0vPllYf0U8ZL1uVX","level":0,"time":"2023-01-03T15:40:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"lGwX0TE0NDvKO90wrUD4","level":0,"time":"2023-01-03T15:45:46+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"0zxefPLVcIrHZioIXsyo","level":0,"time":"2023-01-03T15:55:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"4fNNlmzHnOKa3b5QdiXx","level":0,"time":"2023-01-03T16:05:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"1S2BkMIacw26RZd1sQ7P","level":0,"time":"2023-01-03T16:15:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"2TzOhCpHUFZBZFvbLGwK","level":0,"time":"2023-01-03T16:25:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"7BhdIEB7BBUNKiVzKo7h","level":0,"time":"2023-01-03T16:35:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"R73J8iRoqj4aNdNhR3en","level":0,"time":"2023-01-03T16:45:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"2wF0IXiVyI2uAiEbW9iq","level":0,"time":"2023-01-03T16:51:43+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"GIMTCu9KKi4ZdoVWxNXu","level":0,"time":"2023-01-03T17:00:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"qdEu3vPssqw7rDCkNzM9","level":0,"time":"2023-01-03T17:10:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"6RBJlKqW8EGxm86dYe98","level":0,"time":"2023-01-03T17:20:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"1 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"6dW1r3yjueo7KINwTpI3","level":0,"time":"2023-01-03T17:30:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"1 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"ga7ax3jOGwe4IsncglHT","level":0,"time":"2023-01-03T17:40:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"1 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"DX6lZN5tpL5xSY0Jd0NP","level":0,"time":"2023-01-03T17:50:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"1 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"xWB4SUtHrc1pAs4CxHFm","level":0,"time":"2023-01-03T17:55:44+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"1 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"ai5Ni0myUVtObTOCOt6p","level":0,"time":"2023-01-03T18:05:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"1 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"o4AeRsGv10ux8u4nyG4m","level":0,"time":"2023-01-03T18:15:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"1 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"BQc9jowaGyZxme0r8PNQ","level":0,"time":"2023-01-03T18:25:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"E8fAgupgQgSEmHVz2BfA","level":0,"time":"2023-01-03T18:35:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"1ayp8QTCsiPUo1CPSQDN","level":0,"time":"2023-01-03T18:45:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"L8YRJlZTUFoYyHVcXCsX","level":0,"time":"2023-01-03T18:55:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"PMmBUcjrkv7oYiFoNoXh","level":0,"time":"2023-01-03T19:00:47+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"K3oIMBOEGN1pCYxI6Jrq","level":0,"time":"2023-01-03T19:10:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"DmL91LfFVt7juxyVWpV3","level":0,"time":"2023-01-03T19:20:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"vPIqEyRL3Abu6nYhAm88","level":0,"time":"2023-01-03T19:30:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"6Xn2sGUAeMGfeykCwU1M","level":0,"time":"2023-01-03T19:40:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"qye0BcQf1ha6JnoPAWE1","level":0,"time":"2023-01-03T19:50:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"NA28bHtDgKCsBrlNE2NF","level":0,"time":"2023-01-03T20:00:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}
{"reqId":"zc2066G84ZoHcXkwlJJc","level":0,"time":"2023-01-03T20:10:00+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"0 reminders to process","userAgent":"--","version":"25.0.2.3","data":{"app":"dav"}}

miaulalala · 2023-01-03T21:21:20Z

Thanks! Is that consistent with the alert spamming you're getting?

provokateurin · 2023-01-03T21:31:36Z

Yes, I always get 7 notifications for this event.

miaulalala · 2023-01-03T21:42:41Z

If you're up for it, we could try patching your instance with some more logging to see where why this is happening. Would you be game for that?

provokateurin · 2023-01-03T21:43:38Z

Sure, just not today. Could we do this next week when I'm back to work?

miaulalala · 2023-01-18T10:01:09Z

Debugging findings:

Two Error messages:

{
  "reqId": "tdl7w2mTm7Svxm8WP89x",
  "level": 3,
  "time": "2023-01-18T09:50:02+00:00",
  "remoteAddr": "",
  "user": "--",
  "app": "core",
  "method": "",
  "url": "--",
  "message": "Error while running background job (class: OCA\\DAV\\BackgroundJob\\EventReminderJob, arguments: )",
  "userAgent": "--",
  "version": "25.0.2.3",
  "exception": {
    "Exception": "Sabre\\VObject\\Recur\\MaxInstancesExceededException",
    "Message": "Recurring events are only allowed to generate 3500",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/html/apps/dav/lib/CalDAV/Reminder/ReminderService.php",
        "line": 485,
        "function": "valid",
        "class": "Sabre\\VObject\\Recur\\EventIterator",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/apps/dav/lib/CalDAV/Reminder/ReminderService.php",
        "line": 198,
        "function": "deleteOrProcessNext",
        "class": "OCA\\DAV\\CalDAV\\Reminder\\ReminderService",
        "type": "->",
        "args": [
          [
            415,
            1,
            1503770,
            true,
            "428c2c4d-a640-41d7-a3f4-4270798ff0b0",
            1674039000,
            false,
            "7bef06bc81b653db316686d1c4b47ee2",
            "1882e64e3cc36a9fee42ba7cc511220b",
            "DISPLAY",
            true,
            1674035400,
            false,
            null,
            "Personal",
            "principals/users/kate"
          ],
          {
            "__class__": "Sabre\\VObject\\Component\\VEvent",
            "parent": {
              "__class__": "Sabre\\VObject\\Component\\VCalendar",
              "parent": null,
              "name": "VCALENDAR"
            },
            "name": "VEVENT"
          }
        ]
      },
      {
        "file": "/var/www/html/apps/dav/lib/BackgroundJob/EventReminderJob.php",
        "line": 68,
        "function": "processReminders",
        "class": "OCA\\DAV\\CalDAV\\Reminder\\ReminderService",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/lib/public/BackgroundJob/Job.php",
        "line": 78,
        "function": "run",
        "class": "OCA\\DAV\\BackgroundJob\\EventReminderJob",
        "type": "->",
        "args": [
          null
        ]
      },
      {
        "file": "/var/www/html/lib/public/BackgroundJob/TimedJob.php",
        "line": 103,
        "function": "start",
        "class": "OCP\\BackgroundJob\\Job",
        "type": "->",
        "args": [
          {
            "__class__": "OC\\BackgroundJob\\JobList"
          }
        ]
      },
      {
        "file": "/var/www/html/lib/public/BackgroundJob/TimedJob.php",
        "line": 93,
        "function": "start",
        "class": "OCP\\BackgroundJob\\TimedJob",
        "type": "->",
        "args": [
          {
            "__class__": "OC\\BackgroundJob\\JobList"
          }
        ]
      },
      {
        "file": "/var/www/html/cron.php",
        "line": 152,
        "function": "execute",
        "class": "OCP\\BackgroundJob\\TimedJob",
        "type": "->",
        "args": [
          {
            "__class__": "OC\\BackgroundJob\\JobList"
          },
          {
            "__class__": "OC\\Log"
          }
        ]
      }
    ],
    "File": "/var/www/html/3rdparty/sabre/vobject/lib/Recur/EventIterator.php",
    "Line": 306,
    "message": "Error while running background job (class: OCA\\DAV\\BackgroundJob\\EventReminderJob, arguments: )",
    "exception": {},
    "CustomMessage": "Error while running background job (class: OCA\\DAV\\BackgroundJob\\EventReminderJob, arguments: )"
  }
}

{
  "reqId": "tdl7w2mTm7Svxm8WP89x",
  "level": 3,
  "time": "2023-01-18T09:50:01+00:00",
  "remoteAddr": "",
  "user": "--",
  "app": "PHP",
  "method": "",
  "url": "--",
  "message": "Undefined array key \"{http://sabredav.org/ns}email-address\" at /var/www/html/apps/dav/lib/Connector/Sabre/Principal.php#620",
  "userAgent": "--",
  "version": "25.0.2.3",
  "exception": {
    "Exception": "Error",
    "Message": "Undefined array key \"{http://sabredav.org/ns}email-address\" at /var/www/html/apps/dav/lib/Connector/Sabre/Principal.php#620",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/html/apps/dav/lib/Connector/Sabre/Principal.php",
        "line": 620,
        "function": "onError",
        "class": "OC\\Log\\ErrorHandler",
        "type": "::",
        "args": [
          2,
          "Undefined array key \"{http://sabredav.org/ns}email-address\"",
          "/var/www/html/apps/dav/lib/Connector/Sabre/Principal.php",
          620
        ]
      },
      {
        "file": "/var/www/html/apps/dav/lib/CalDAV/Reminder/ReminderService.php",
        "line": 188,
        "function": "getEmailAddressesOfPrincipal",
        "class": "OCA\\DAV\\Connector\\Sabre\\Principal",
        "type": "->",
        "args": [
          [
            "principals/users/kate",
            "Kate",
            "INDIVIDUAL",
            "en"
          ]
        ]
      },
      {
        "file": "/var/www/html/apps/dav/lib/BackgroundJob/EventReminderJob.php",
        "line": 68,
        "function": "processReminders",
        "class": "OCA\\DAV\\CalDAV\\Reminder\\ReminderService",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/html/lib/public/BackgroundJob/Job.php",
        "line": 78,
        "function": "run",
        "class": "OCA\\DAV\\BackgroundJob\\EventReminderJob",
        "type": "->",
        "args": [
          null
        ]
      },
      {
        "file": "/var/www/html/lib/public/BackgroundJob/TimedJob.php",
        "line": 103,
        "function": "start",
        "class": "OCP\\BackgroundJob\\Job",
        "type": "->",
        "args": [
          {
            "__class__": "OC\\BackgroundJob\\JobList"
          }
        ]
      },
      {
        "file": "/var/www/html/lib/public/BackgroundJob/TimedJob.php",
        "line": 93,
        "function": "start",
        "class": "OCP\\BackgroundJob\\TimedJob",
        "type": "->",
        "args": [
          {
            "__class__": "OC\\BackgroundJob\\JobList"
          }
        ]
      },
      {
        "file": "/var/www/html/cron.php",
        "line": 152,
        "function": "execute",
        "class": "OCP\\BackgroundJob\\TimedJob",
        "type": "->",
        "args": [
          {
            "__class__": "OC\\BackgroundJob\\JobList"
          },
          {
            "__class__": "OC\\Log"
          }
        ]
      }
    ],
    "File": "/var/www/html/lib/private/Log/ErrorHandler.php",
    "Line": 92,
    "CustomMessage": "--"
  }
}

Happens with recurrences that have no end date, but could also happen for others, we haven't imvestigated that issue.

miaulalala · 2023-01-18T10:04:48Z

@provokateurin did you say you didn't have an email address set for the user kate?

provokateurin · 2023-01-18T10:12:45Z

Yes, no email set

tcitworld · 2023-01-18T10:22:43Z

The first one needs something similar to nextcloud/server#32191 for deleteOrProcessNext.

The second one is related to nextcloud/server#34909 when no emails are set indeed.

st3iny · 2023-01-18T11:07:21Z

The first one needs something similar to nextcloud/server#32191 for deleteOrProcessNext.

The second one is related to nextcloud/server#34909 when no emails are set indeed.

Ahh, the second one is my fault. I assumed that retrieving a non-existant key would just yield null (like in JavaScript). I'll open a PR asap.

miaulalala · 2023-01-18T11:09:04Z

I'll add the exception try- catch.

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

…hout end date Ref nextcloud/calendar#4811 Signed-off-by: Anna Larch <anna@nextcloud.com>

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

provokateurin · 2023-01-26T10:37:46Z

After upgrading to 25.0.3 (from 25.0.2) this no longer happens. I didn't update anything else in between and the test case also no longer fails. Also no error shows up in the logs anymore.

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

st3iny · 2023-01-26T13:35:50Z

That's very nice to hear. Both related PRs have been merged at this point, too.

provokateurin · 2023-01-26T13:37:02Z

Ah I thought this was a problem now because the Calendar app wasn't updated, but it was actually a problem in the server!

st3iny · 2023-01-26T13:38:10Z

Ah I thought this was a problem now because the Calendar app wasn't updated, but it was actually a problem in the server!

The whole calendar backend actually lives in the server repo. The calendar app is mainly just a browser "frontend".

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

provokateurin changed the title ~~Push notification spammed for calendar event~~ Notification spammed for calendar event Dec 15, 2022

provokateurin transferred this issue from nextcloud/notifications Dec 15, 2022

This comment was marked as off-topic.

Sign in to view

miaulalala added 1. to develop Accepted and waiting to be taken care of bug regression Regression of a previous working feature labels Jan 3, 2023

st3iny added a commit to nextcloud/server that referenced this issue Jan 18, 2023

fix(dav): check if principal has email address before accessing it

0bab66f

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

st3iny mentioned this issue Jan 18, 2023

fix(dav): check if principal has email address before accessing it nextcloud/server#36210

Merged

4 tasks

miaulalala added a commit to nextcloud/server that referenced this issue Jan 18, 2023

fix(dav): catch MaxInstancesExceedeException for recurring events wit…

4f56003

…hout end date Ref nextcloud/calendar#4811 Signed-off-by: Anna Larch <anna@nextcloud.com>

miaulalala mentioned this issue Jan 18, 2023

fix(dav): catch MaxInstancesExceededException for recurring events without end date nextcloud/server#36211

Merged

4 tasks

miaulalala added a commit to nextcloud/server that referenced this issue Jan 18, 2023

fix(dav): catch MaxInstancesExceedeException for recurring events wit…

a9264b0

…hout end date Ref nextcloud/calendar#4811 Signed-off-by: Anna Larch <anna@nextcloud.com>

backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Jan 18, 2023

fix(dav): catch MaxInstancesExceedeException for recurring events wit…

f14d6fa

…hout end date Ref nextcloud/calendar#4811 Signed-off-by: Anna Larch <anna@nextcloud.com>

backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Jan 19, 2023

fix(dav): catch MaxInstancesExceedeException for recurring events wit…

c85d6d8

…hout end date Ref nextcloud/calendar#4811 Signed-off-by: Anna Larch <anna@nextcloud.com>

st3iny added a commit to nextcloud/server that referenced this issue Jan 24, 2023

fix(dav): check if principal has email address before accessing it

bbda231

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Jan 26, 2023

fix(dav): check if principal has email address before accessing it

22dc3a8

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

st3iny closed this as completed Jan 26, 2023

st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Jan 26, 2023

backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Jan 26, 2023

fix(dav): check if principal has email address before accessing it

6728b4b

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Jan 26, 2023

fix(dav): check if principal has email address before accessing it

f5a6a69

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Jan 26, 2023

fix(dav): check if principal has email address before accessing it

31fe1da

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

summersab pushed a commit to summersab/server that referenced this issue Feb 9, 2023

fix(dav): check if principal has email address before accessing it

e8a9009

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

s8321414 pushed a commit to MODAODF/odfweb that referenced this issue May 4, 2023

fix(dav): check if principal has email address before accessing it

58255fd

Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Notification spammed for calendar event #4811

Notification spammed for calendar event #4811

provokateurin commented Dec 8, 2022 •

edited

provokateurin commented Dec 8, 2022

nickvergessen commented Dec 8, 2022

provokateurin commented Dec 8, 2022

provokateurin commented Dec 15, 2022

provokateurin commented Dec 15, 2022

nickvergessen commented Dec 15, 2022

provokateurin commented Dec 15, 2022

This comment was marked as off-topic.

This comment was marked as off-topic.

miaulalala commented Jan 2, 2023

st3iny commented Jan 2, 2023 •

edited

aledef commented Jan 2, 2023

miaulalala commented Jan 2, 2023

provokateurin commented Jan 2, 2023

st3iny commented Jan 3, 2023

provokateurin commented Jan 3, 2023

provokateurin commented Jan 3, 2023

miaulalala commented Jan 3, 2023

provokateurin commented Jan 3, 2023

miaulalala commented Jan 3, 2023

provokateurin commented Jan 3, 2023

miaulalala commented Jan 18, 2023

miaulalala commented Jan 18, 2023

provokateurin commented Jan 18, 2023

tcitworld commented Jan 18, 2023 •

edited

st3iny commented Jan 18, 2023

miaulalala commented Jan 18, 2023

provokateurin commented Jan 26, 2023

st3iny commented Jan 26, 2023

provokateurin commented Jan 26, 2023

st3iny commented Jan 26, 2023

Notification spammed for calendar event #4811

Notification spammed for calendar event #4811

Comments

provokateurin commented Dec 8, 2022 • edited

Steps to reproduce

Expected behaviour

Actual behaviour

Server configuration

provokateurin commented Dec 8, 2022

nickvergessen commented Dec 8, 2022

provokateurin commented Dec 8, 2022

provokateurin commented Dec 15, 2022

provokateurin commented Dec 15, 2022

nickvergessen commented Dec 15, 2022

provokateurin commented Dec 15, 2022

This comment was marked as off-topic.

This comment was marked as off-topic.

miaulalala commented Jan 2, 2023

st3iny commented Jan 2, 2023 • edited

aledef commented Jan 2, 2023

miaulalala commented Jan 2, 2023

provokateurin commented Jan 2, 2023

st3iny commented Jan 3, 2023

provokateurin commented Jan 3, 2023

provokateurin commented Jan 3, 2023

miaulalala commented Jan 3, 2023

provokateurin commented Jan 3, 2023

miaulalala commented Jan 3, 2023

provokateurin commented Jan 3, 2023

miaulalala commented Jan 18, 2023

miaulalala commented Jan 18, 2023

provokateurin commented Jan 18, 2023

tcitworld commented Jan 18, 2023 • edited

st3iny commented Jan 18, 2023

miaulalala commented Jan 18, 2023

provokateurin commented Jan 26, 2023

st3iny commented Jan 26, 2023

provokateurin commented Jan 26, 2023

st3iny commented Jan 26, 2023

provokateurin commented Dec 8, 2022 •

edited

st3iny commented Jan 2, 2023 •

edited

tcitworld commented Jan 18, 2023 •

edited