Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when detected timezone is UTC #711

Closed
3 tasks
georgehrke opened this issue Jan 30, 2018 · 7 comments · Fixed by #1560
Closed
3 tasks

Show warning when detected timezone is UTC #711

georgehrke opened this issue Jan 30, 2018 · 7 comments · Fixed by #1560
Labels
3. to review Waiting for reviews bug
Milestone

Comments

@georgehrke
Copy link
Member

georgehrke commented Jan 30, 2018

Steps to reproduce

  1. open Firefox
  2. goto about:config
  3. enable privacy.resistFingerprinting
  4. open calendar app

Expected behaviour

Calendar works just fine

Actual behaviour

Calendar view (day / week / month) displays everything as UTC

What to do now:

  • research what parts about firefox are different in privacy.resistFingerprinting mode
  • isolate the issue in our code - Is it our code or a dependency?
  • fix / report upstream

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of bug needs research labels Jan 30, 2018
@georgehrke
Copy link
Member Author

@georgehrke
Copy link
Member Author

With Firefox 59.0b5, https://pellepim.bitbucket.io/jstz/ just gives me UTC.

And according to an admin in the firefox Channel of the Mozilla IRC, privacy.resistFingerprinting will make users appear to be in UTC:
https://mozilla.logbot.info/firefox/20180130#c14213397

So I would propose the following:

@georgehrke georgehrke changed the title Calendar view is UTC only in Firefox if privacy.resistFingerprinting is enabled Calendar view is UTC only in Tor Jan 30, 2018
@AshotN
Copy link

AshotN commented Feb 8, 2018

Why not default to the server timezone and allow individual users the ability to change in their respective settings

@georgehrke
Copy link
Member Author

Default should always be detecting the users current time zone, because that works for most cases.

If we can only detect UTC, because the user is using some anti fingerprinting mechanism, we should simply ask them to tell us their timezone.

Where should the server timezone come in here?
I really oppose abolishing our automatic timezone detection, because it works just fine in most cases.

@AshotN
Copy link

AshotN commented Feb 8, 2018

The automatic system would be fine if there was a manual override.

@georgehrke
Copy link
Member Author

Yes, that's what this entire ticket and the ticket #586 i linked above is just about

@georgehrke georgehrke added this to the 1.6.1-next-maintenance milestone Feb 8, 2018
@AshotN
Copy link

AshotN commented Feb 10, 2018

A temporary work-around is to just not use the NextCloud Calendar app interface. Rather link a separate program

@georgehrke georgehrke changed the title Calendar view is UTC only in Tor Show warning when detected timezone is UTC Feb 26, 2018
@georgehrke georgehrke modified the milestones: 1.6.1-next-maintenance, 1.6.2 Mar 6, 2018
@georgehrke georgehrke modified the milestones: 1.6.2, 2.0.0 beta2 Sep 8, 2018
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants