Public sharing

[georgehrke]

No description provided.

[georgehrke]

@tcitworld

[raghunayyar]

Can you add the steps to check?
This is one massive Pull Request. :)

[coveralls]

Coverage decreased (-0.5%) to 25.262% when pulling e7e5e33 on public-sharing into 5d7b19f on master.

[tcitworld]

@raghunayyar

• Check that it doesn't break anything without the server change : CalDAV calendar public sharing server#1197 (i.e work on NC < 11).
• Test that the features comes correctly with the server change
• Test publish link is accessible and contains all events
• Test email is correctly sent with link

Todos :

• More tests can be added
• OpenGraph informations on a link

[coveralls]

Coverage decreased (-0.5%) to 25.262% when pulling 2c6b339 on public-sharing into 5d7b19f on master.

[coveralls]

Coverage decreased (-0.5%) to 25.191% when pulling a06fb63 on public-sharing into 30b3eae on master.

[georgehrke]

pr in server: nextcloud/server#1197

[georgehrke]

@tcitworld Can you take care of rebasing? :)

[tcitworld]

How did you know ? I was doing it right now !

[georgehrke]

hehe 🙈

[coveralls]

Coverage decreased (-0.5%) to 25.221% when pulling 56dbb6a on public-sharing into 76c0b64 on master.

[coveralls]

Coverage decreased (-0.6%) to 27.887% when pulling 674af79 on public-sharing into 6499ac9 on master.

[coveralls]

Coverage decreased (-0.6%) to 27.887% when pulling 674af79 on public-sharing into 6499ac9 on master.

[coveralls]

Coverage decreased (-0.6%) to 27.898% when pulling 856d761 on public-sharing into 8c471dd on master.

[georgehrke]

nextcloud/server#1197 was merged, so let's get this in by end of the week :)

[tcitworld]

It's the end of the week. ;-) Not sure if 856d761 works properly.

[georgehrke]

I'm not too happy, that these are in the settings. It's not really settings and has a bad discoverability I think. But we can take care of this in a follow-up PR. not a blocker

[georgehrke]

• please only add the public graph thing to main.php when it's a public page

[georgehrke]

Send button jumps into next line when list is scrollable

[georgehrke]

🙈

[georgehrke]

the JSONResponse call should be moved to sendEmailPublicLink

[georgehrke]

Right now we are only sending an html-body. Please also provide a plain text message.
see http://swiftmailer.org/docs/messages.html#setting-the-body-content

We should not force users to use html emails.

[georgehrke]

Looking at the source code of OCA\Mail\Message, I suppose that you first have to use setPlainBody and afterwords set the html content with setHtmlBody

https://github.com/nextcloud/server/blob/8c7d7d7746e76b77ad86cee3aae5dbd4d1bcd896/lib/private/Mail/Message.php#L211