Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border styles for grid, highlight full-hour horizontal lines, fix #119 #140

Merged
merged 1 commit into from
Oct 19, 2016

Conversation

jancborchardt
Copy link
Member

Fix #119, please review @moy @tcitworld @nextcloud/calendar :)

Before:
capture du 2016-10-19 11-29-28

After (all full-hour grid lines are darker #eee, just like the row lines in Files, user management and elsewhere):
capture du 2016-10-19 11-28-06

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added 3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. labels Oct 19, 2016
@mention-bot
Copy link

@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @raghunayyar, @tcitworld and @georgehrke to be potential reviewers.

@skjnldsv
Copy link
Member

👍 okay!

@georgehrke
Copy link
Member

👍

@coveralls
Copy link

coveralls commented Oct 19, 2016

Coverage Status

Coverage remained the same at 42.891% when pulling 5b8a7df on grid-lines into feec09b on master.

@moy
Copy link

moy commented Oct 19, 2016

Much better after than before indeed IMHO. It's still rather light: for example, I'm now seeing this from my laptop's screen which has a TN panel (=> gets different contrast depending on the viewing angle). Contrast is perfect when viewed with the right angle, but the grid still disappears quickly when looking at the screen from above.

IOW, If that was just me I'd use a slightly darker color, but I'm OK with the proposal too.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants