import empty calendars #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tcitworld and @raghunayyar to be potential reviewers. |
|
Perfect. 👍 |
|
Seems good but build failed? |
|
that was a travis error at that time. I started the tests again and now they pass. |
skjnldsv
reviewed
Dec 3, 2016
| })[0]; | ||
| if (calendar.enabled) { | ||
| }); | ||
| if (calendar && calendar.enabled) { | ||
| calendar.enabled = false; | ||
| calendar.enabled = true; |
There was a problem hiding this comment.
What is the point of this?
only one is needed right?
There was a problem hiding this comment.
This triggers a rerendering of the events in this calendar
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #194
please review @tcitworld @nextcloud/calendar