fix handling of recurrence ID #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bugfix at ical.js: kewisch/ical.js#302 |
georgehrke
added
2. developing
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
georgehrke
force-pushed
the
bugfix/142/fix_handling_of_recurrence_id
branch
from
7f7ceff
to
01c72e6
Compare
georgehrke
added
3. to review
|
There are two new test cases:
I'd like to merge this, because the fix for 1 is important. |
|
Yeah let's comment out the failing test with a TODO comment until it's merged upstream. |
tcitworld
approved these changes
Apr 9, 2017
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #142
test will fail because of what I think is a bug in ical.js.
Will send them a pr.