Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mathieu schopfer parsing schedule #44

Closed
wants to merge 2 commits into from

Conversation

georgehrke
Copy link
Member

continuing the discussion here

@MathieuSchopfer

@georgehrke georgehrke added the 3. to review Waiting for reviews label Sep 17, 2016
@coveralls
Copy link

coveralls commented Sep 17, 2016

Coverage Status

Coverage decreased (-0.2%) to 25.566% when pulling 270db16 on MathieuSchopfer-parsing_schedule into e6cb612 on master.

@tcitworld
Copy link
Member

@MathieuSchopfer Can you add a few tests ?

@MathieuSchopfer
Copy link
Contributor

@tcitworld Sorry, what for tests ?
See this fiddle for an equivalent example.

@tcitworld
Copy link
Member

tcitworld commented Sep 23, 2016

Test that entering 2:15-4:30 Title correctly creates an event with the according title and correct times.

Thanks for the fiddle link, I'll try to add some.

@MathieuSchopfer
Copy link
Contributor

Oh ok, you want to automate the tests. I have to admit, I have never done it before.
Where should they be located (I guess calendar/tests/js/unit/controllers/) ? And how do you actually run them?

@tcitworld
Copy link
Member

tcitworld commented Sep 23, 2016

In fact I think it would be better to have this code as a service. cc @georgehrke

Tests are run with make test. If you want just js tests, cd js/ && grunt karma

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of and removed 3. to review Waiting for reviews labels Apr 6, 2017
@georgehrke
Copy link
Member Author

This pull-request lacks support for different locales, which will definitely not be an easy task to implement.

Closing in favour of #17 for now.

@georgehrke georgehrke closed this Sep 13, 2019
@georgehrke georgehrke deleted the MathieuSchopfer-parsing_schedule branch September 13, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants