Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add link to the Thunderbird holiday calendar page #5166

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Apr 27, 2023

This is the MVP version of #962. We plan to add an advanced modal to our app later so users don't have to leave the page.

Before After
Bildschirmfoto vom 2023-04-27 09-24-53 Bildschirmfoto vom 2023-04-27 09-24-06

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews enhancement New feature request labels Apr 27, 2023
@ChristophWurst ChristophWurst self-assigned this Apr 27, 2023
@ChristophWurst ChristophWurst mentioned this pull request Apr 27, 2023
3 tasks
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (e0f778c) 22.59% compared to head (5f071dd) 22.58%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5166      +/-   ##
============================================
- Coverage     22.59%   22.58%   -0.01%     
  Complexity      373      373              
============================================
  Files           236      236              
  Lines         11475    11480       +5     
  Branches       2149     2152       +3     
============================================
  Hits           2593     2593              
- Misses         8882     8887       +5     
Flag Coverage Δ
javascript 14.01% <0.00%> (-0.01%) ⬇️
php 63.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/AppNavigation/CalendarList/CalendarListNew.vue 0.00% <0.00%> (ø)
src/components/AppointmentConfigModal.vue 0.00% <0.00%> (ø)
...s/AppointmentConfigModal/CheckedDurationSelect.vue 0.00% <ø> (ø)
...rc/components/AppointmentConfigModal/TextInput.vue 0.00% <0.00%> (ø)
.../fullcalendar/localization/dateFormattingConfig.js 0.00% <ø> (ø)
src/models/appointmentConfig.js 0.00% <0.00%> (ø)
src/store/settings.js 87.71% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the feat/thunderbird-holiday-subscription-link branch from 3663f44 to 5f071dd Compare April 27, 2023 09:20
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 27, 2023
@ChristophWurst ChristophWurst merged commit c5f4980 into main Apr 27, 2023
@ChristophWurst ChristophWurst deleted the feat/thunderbird-holiday-subscription-link branch April 27, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants