Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webcal): Name button *Subscribed* for existing calendars #5195

Merged
merged 1 commit into from
May 4, 2023

Conversation

ChristophWurst
Copy link
Member

Fixes #5192

Before After
Bildschirmfoto vom 2023-05-04 12-51-34 Bildschirmfoto vom 2023-05-04 12-47-58

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews enhancement New feature request labels May 4, 2023
@ChristophWurst ChristophWurst self-assigned this May 4, 2023
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (12deb19) 22.46% compared to head (d66843d) 22.43%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5195      +/-   ##
============================================
- Coverage     22.46%   22.43%   -0.04%     
  Complexity      373      373              
============================================
  Files           237      237              
  Lines         11575    11573       -2     
  Branches       2176     2176              
============================================
- Hits           2600     2596       -4     
- Misses         8975     8977       +2     
Flag Coverage Δ
javascript 13.90% <ø> (-0.04%) ⬇️
php 63.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/Subscription/HolidaySubscriptionPicker.vue 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristophWurst ChristophWurst merged commit 7008557 into main May 4, 2023
25 of 26 checks passed
@ChristophWurst ChristophWurst deleted the feat/webcal/subscribed-holiday-calendars branch May 4, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request
Projects
Development

Successfully merging this pull request may close these issues.

Give feedback on subscribed holiday calendar
3 participants