don't filter results while sharing

[akhil1508]

• Share only works by display name right now

• Search by email to share calendar is broken completely as there is a filterBy option in vue-select whose return value defaults to return (label || '').toLocaleLowerCase().indexOf(search.toLocaleLowerCase()) > -1

  • label in our code is set to displayName so only search by displayName works

• Since we already get our results by searching(DAV & OCS), I don't see why we need the filterBy option in the first place

  • So I just make the return value true
  • In case we do need the option, we should make it check for both displayName and email attributes

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f45fc62) 24.45% compared to head (6e1945d) 24.44%.
Report is 7 commits behind head on main.

Files	Patch %	Lines
.../AppNavigation/EditCalendarModal/SharingSearch.vue	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #5645      +/-   ##
============================================
- Coverage     24.45%   24.44%   -0.01%     
  Complexity      418      418              
============================================
  Files           243      243              
  Lines         10833    10835       +2     
  Branches       1776     1776              
============================================
  Hits           2649     2649              
- Misses         8184     8186       +2     

Flag	Coverage Δ
javascript	15.50% <0.00%> (-0.01%)	⬇️
php	61.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChristophWurst]

Not verified but if the limitation comes from with NcSelect we introduced this limitation with #5323. cc @hamza221

[akhil1508]

@ChristophWurst Any update? It is crucial for me to allow share using email addresses :)

I've tested the code and it works well.

[hamza221]

@akhil1508 Thank you for your contribution

[hamza221]

/backport to stable4.4

[hamza221]

/backport to stable4.5

[hamza221]

/backport to stable4.6

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!