Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigation when clicking on the grid on a custom week/month #5999

Merged
merged 2 commits into from May 14, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented May 10, 2024

Follow-up to #5891
Reverts #5995

I converted the FullCalendar options to a computed prop again. It still works in private and public widgets. I assume this was just an oversight. This also means that we can get rid of some reactivity hacks as the computed prop is now properly reactive again.

How to reproduce

  1. Open the calendar app.
  2. Switch to month view.
  3. Navigate to the next month using the top left navigation buttons.
  4. Click on some day.
  5. Observe the grid changing back to the previous month which includes today.

Regression testing

Things that I tested successfully:

  1. Main calendar grid view in the app.
  2. Resize observer still works (see fix: delay initializing the resize observer until FC is ready #5995).
  3. Private widgets in a Talk room (internal link).
  4. Public widgets in a Talk room (public link share).

I converted the FullCalendar options to a computed prop again. It still
works in private and public widgets. I assume this was just an oversight.
This also means that we can get rid of some reactivity hacks again as
the computed prop is now properly reactive again.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added the 3. to review Waiting for reviews label May 10, 2024
@st3iny st3iny requested a review from hamza221 May 10, 2024 12:17
@st3iny st3iny self-assigned this May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 23.54%. Comparing base (4f2caf6) to head (a633a5a).
Report is 3 commits behind head on main.

Files Patch % Lines
src/components/CalendarGrid.vue 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5999      +/-   ##
============================================
+ Coverage     23.51%   23.54%   +0.02%     
  Complexity      455      455              
============================================
  Files           246      246              
  Lines         11718    11707      -11     
  Branches       2154     2142      -12     
============================================
  Hits           2756     2756              
+ Misses         8647     8637      -10     
+ Partials        315      314       -1     
Flag Coverage Δ
javascript 15.18% <0.00%> (+0.01%) ⬆️
php 58.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit a40a200.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't break Widgets ✅

@st3iny st3iny added this to the v4.8.0 milestone May 14, 2024
@st3iny

This comment was marked as off-topic.

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label May 14, 2024
@st3iny st3iny merged commit e47c4e7 into main May 14, 2024
40 of 41 checks passed
@st3iny st3iny deleted the fix/calendar-options-computed-prop branch May 14, 2024 07:25

This comment was marked as resolved.

@st3iny
Copy link
Member Author

st3iny commented May 14, 2024

Hmm, private widgets were not backported to stable4.7 so we should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request A backport was requested for this pull request
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants