Remove bower #884
Merged
Remove bower #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
added
3. to review
* Uses PHPUnit 6.5 (requires PHP 7.0+, but we got rid with NC 14 (see nextcloud/server#7368) * Namespaces are rewritten * If composer isn't installed, it installs it (taken from nextcloud/news) Signed-off-by: Thomas Citharel <tcit@tcit.fr> Remove PHPUnit Download in CI Signed-off-by: Thomas Citharel <tcit@tcit.fr> Properly handle phpunit on travis for 5.6 Signed-off-by: Thomas Citharel <tcit@tcit.fr> Remove trouble composer.lock Signed-off-by: Thomas Citharel <tcit@tcit.fr> Don't install composer deps twice on CI Signed-off-by: Thomas Citharel <tcit@tcit.fr>
|
For PHP 5.6 compatibility and only in this case, we keep using PHPUnit 5.7.
|
georgehrke
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes bower and makes it work with npm intead.
The second commit make tests use a local version of phpunit instead of a global one (it's always too up-to-date on my system), which can be installed through composer.