Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accesskeys to the datepicker container buttons #929

Closed
wants to merge 2 commits into from
Closed

Add accesskeys to the datepicker container buttons #929

wants to merge 2 commits into from

Conversation

jaller94
Copy link

As it had been mentioned in #157, I would prefer keyboard shortcuts which do not require combinations. There are also accessibility issues known when using accesskey described on MDN:
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey

Still, I have the opinion that this would be a great quick fix to make some sort of keyboard shortcuts available until there is a JavaScript handling available.

  • P for the previous period
  • N for the next period
  • D for the day view
  • W for the week view
  • M for the month view
  • T for the current day (today)

@jaller94 jaller94 changed the title Add accesskeys to the Day, Week, Month and Today buttons Add accesskeys to the datepicker container buttons Oct 20, 2018
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with having this for the time being, but it's kind of useless unless documented.

@jaller94
Copy link
Author

I noticed that Nextcloud Mail has a page for keyboard shortcuts. It is hidden in the settings.
https://github.com/nextcloud/mail/blob/master/js/templates/keyboard-shortcuts.html

And from the main app I found a file that handles most of the single key shortcuts:
https://github.com/nextcloud/server/blob/master/apps/files/js/keyboardshortcuts.js

@georgehrke
Copy link
Member

Closing because of the restrictions with accesskey.
This needs to be reimplemented in the Vue branch and we should use that opportunity to use some proper Vue Plugin for that.

@georgehrke georgehrke closed this Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants