Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for PHP 7.4 #93

Merged
merged 1 commit into from
May 17, 2023
Merged

feat: add support for PHP 7.4 #93

merged 1 commit into from
May 17, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented May 17, 2023

Followup to #92

This partially reverts a8aa431.

I forgot to fully revert all changes as they were split across 2 commits/PRs. There were no code changes regarding the drop. It was a purely cosmetic change.

@st3iny st3iny added 3. to review Waiting for reviews enhancement New feature or request labels May 17, 2023
@st3iny st3iny requested review from kesselb and miaulalala May 17, 2023 06:28
@st3iny st3iny self-assigned this May 17, 2023
@st3iny
Copy link
Member Author

st3iny commented May 17, 2023

Green CI should be sufficient as it covers php 7.4. I'll do a full test right before the release.

This partially reverts a8aa431.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny merged commit cf4d1ef into main May 17, 2023
16 checks passed
@st3iny st3iny deleted the feat/add-php7.4 branch May 17, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants