Merge pull request #1048 from nextcloud/fix/noid/circle-link-no-contacts

do not generate link if no front-end
nextcloud · Jun 13, 2022 · 70b4e99 · 70b4e99
2 parents 0f675b3 + b8493f3
commit 70b4e99
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/lib/Model/ModelManager.php b/lib/Model/ModelManager.php
@@ -31,7 +31,7 @@
 
 namespace OCA\Circles\Model;
 
-use OCA\Circles\Tools\Traits\TNCLogger;
+use Exception;
 use OCA\Circles\AppInfo\Application;
 use OCA\Circles\Db\CircleRequest;
 use OCA\Circles\Db\CoreQueryBuilder;
@@ -57,6 +57,7 @@
 use OCA\Circles\Service\InterfaceService;
 use OCA\Circles\Service\MembershipService;
 use OCA\Circles\Service\RemoteService;
+use OCA\Circles\Tools\Traits\TNCLogger;
 use OCP\IURLGenerator;
 
 /**
@@ -553,10 +554,16 @@ public function fixInstance(string $instance): string {
 	 * @return string
 	 */
 	public function generateLinkToCircle(string $singleId): string {
-		return $this->urlGenerator->linkToRoute(
-			$this->configService->getAppValue(ConfigService::ROUTE_TO_CIRCLE),
-			['singleId' => $singleId]
-		);
+		$path = $this->configService->getAppValue(ConfigService::ROUTE_TO_CIRCLE);
+
+		try {
+			if ($path !== '') {
+				return $this->urlGenerator->linkToRoute($path, ['singleId' => $singleId]);
+			}
+		} catch (Exception $e) {
+		}
+
+		return '';
 	}