feat: Rename to teams #1512
Merged
feat: Rename to teams #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
jancborchardt
previously requested changes
Feb 21, 2024
| @@ -2,7 +2,7 @@ | |||
| <info xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd"> | |||
| <id>circles</id> | |||
| <name>Circles</name> | |||
| <name>Teams</name> | |||
| <summary>Bring cloud-users closer together.</summary> | |||
There was a problem hiding this comment.
This could use a better summary, maybe from @jospoortvliet?
appinfo/info.xml
Outdated
| @@ -2,7 +2,7 @@ | |||
| <info xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd"> | |||
| <id>circles</id> | |||
| <name>Circles</name> | |||
| <name>Teams</name> | |||
| <summary>Bring cloud-users closer together.</summary> | |||
| <description><
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
feat/rename-teams
branch
from
cafd53b
to
c5fd973
Compare
mejo-
requested changes
Feb 27, 2024
lib/Activity/SettingAsModerator.php
Outdated
| @@ -51,7 +51,7 @@ public function getIdentifier() { | |||
| * @since 11.0.0 | |||
| */ | |||
| public function getName() { | |||
| return $this->l10n->t('Any important event in a <strong>Circle</strong> you are moderating'); | |||
| return $this->l10n->t('Any important event in a <strong>Team</strong> you are moderating'); | |||
There was a problem hiding this comment.
Since you use lowercase 'team' elsewhere, maybe also adjust it here?
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
feat/rename-teams
branch
from
c5fd973
to
32a6efa
Compare
|
@mejo- Thanks, adjusted |
mejo-
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly replaced as App name, icon and in translation strings
