allow configuration of one single password per circle

[ArtificialOwl]

• Managing circle's settings from the command line

• Allow multiple configuration to use this feature (in order):

  • Enforcing password protection if the Enforce password protection is enabled.
  • Enforcing password protection if the Circle App is configured to:
    ./occ config:app:set --value '1' circles enforce_password
  • Enforcing password protection if the Circle's settings is configured to:
    ./occ circles:manage:setting y8JczmViR3zZraCXhbpfR8v4x8s5A8c enforce_password true

• Allow the use of a single password when sharing a new file to external members of a circle,

• Allow the use of a single password when adding a new external member to a circle,

• confirm behavior in globalscale env.

• providing API and Feature Request for Contacts

• filtering some setting before sending ocs data about circle

display settings from a circleId

$ ./occ circles:manage:setting y8JczmViR3zZraCXhbpfR8v4x8s5A8c 
{
    "enforce_password": "true",
    "password_single_enabled": "true",
    "password_single": "3|$argon2id$v=19$m=65536,t=4,p=1$NktudFp4UmluSGZtRGhEeA$VJuD1vhKuKG+oFFT1nlmXHU3O3aTUw1ZFkjW8Vw9gxU"
}

Add/Edit setting from a circleId

$ ./occ circles:manage:setting y8JczmViR3zZraCXhbpfR8v4x8s5A8c enforce_password true
$ ./occ circles:manage:setting y8JczmViR3zZraCXhbpfR8v4x8s5A8c password_single_enable true
$ ./occ circles:manage:setting y8JczmViR3zZraCXhbpfR8v4x8s5A8c password_single my_clear_password

Note: when setting the param password_single the clear password will be instantly be hashed

Remote a setting from a circleId

$ ./occ circles:manage:setting y8JczmViR3zZraCXhbpfR8v4x8s5A8c enforce_password --unset

[ArtificialOwl]

/backport to stable23

[ArtificialOwl]

/backport to stable22

[mejo-]

Shouldn't this be strlen($cur) >= 1 && ...? If a password could be strlen(2) before, I suspect it might have been strlen(1) as well? 🤔

[ArtificialOwl]

true, who will use a 1-char password ? :)

[mejo-]

I'm still not sure whether it's a good idea to allow any string as a settings key. Why not maintain a list of allowed settings and error out if users are trying to set an unsupported settings key?

As it is currently - and with only password_single being hashed, I expect plaintext passwords to end up in the database due to typos by the users. E.g. when you do something like occ circles:manage:setting <circle_id> password_sigle my_secret_password (note the typo in "sigle").

[ArtificialOwl]

I am fine with it. 99% of the people will use the front-end to set those settings (with pre-defined keys)

[mejo-]

Sorry, accidently approved despite having comments/questions. Changed to "comment" now.

[mejo-]

again