build fails due to png2ico

[wdehoog]

While trying to follow the build instructions I get the following:
I am using Qt 5.11.1 64-bit for Desktop (MSVC 2017) shell

  C:/XXXXX/nextcloud/desktop-2.5/desktop/theme/colored/256-Nextcloud-icon.png: Width must be multiple of 8 and <256. Height must be <256.
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(209,5): error MSB6006: "cmd.exe" exited with code 1. [C:\XXXXX\nextcloud\desktop-2.5\desktop\build\src\gui\nex
tcloud.vcxproj]
Done Building Project "C:\XXXXX\nextcloud\desktop-2.5\desktop\build\src\gui\nextcloud.vcxproj" (default targets) -- FAILED.

Project "C:\XXXXX\nextcloud\desktop-2.5\desktop\build\ALL_BUILD.vcxproj" (1) is building "C:\XXXXX\nextcloud\desktop-2.5\desktop\build\src\cmd\nextcloudcmd.vcxproj" (10) on node 1 (default targets).
InitializeBuildStatus:
  Creating "nextcloudcmd.dir\Release\nextcloudcmd.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.

It seems to execute:

C:\tools\png2ico.exe C:/XXXXX/nextcloud/desktop-2.5/desktop/build/src/gui/Nextcloud.ico C:/XXXXX/nextcloud/desktop-2.5/desktop/theme/colored/16-Nextcloud-icon.png C:/XXXXX/nextcloud/desktop-2.5/desktop/theme/colored/32-Nextcloud-icon.png C:/XXXXX/nextcloud/desktop-2.5/desktop/theme/colored/48-Nextcloud-icon.png C:/XXXXX/nextcloud/desktop-2.5/desktop/theme/colored/64-Nextcloud-icon.png C:/XXXXX/nextcloud/desktop-2.5/desktop/theme/colored/128-Nextcloud-icon.png C:/XXXXX/nextcloud/desktop-2.5/desktop/theme/colored/256-Nextcloud-icon.png

how can I fix this or proceed the build?

[hiiamok]

@wdehoog Try using this png2ico executable instead:
https://github.com/hiiamok/png2ImageMagickICO/releases/tag/v1.0

See nextcloud/desktop#647

[wdehoog]

@hiiamok and @camilasan thanks. I tested with the executable in x64.zip and it works.