Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITEM2.xxx properties - the url label is not set at all #1027

Closed
j-ed opened this issue Mar 29, 2019 · 6 comments
Closed

ITEM2.xxx properties - the url label is not set at all #1027

j-ed opened this issue Mar 29, 2019 · 6 comments
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@j-ed
Copy link

j-ed commented Mar 29, 2019

The field label of the following URL is not set at all

ITEM2.URL;TYPE=pref;VALUE=URI:http://a-valid-url.de

Expected result:

If the type field only contains pref the corresponding label should be set to the default value Internetseite (German language).

Current result:

20190329_nc-kontakte_empty_url_label

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #1026 (ITEM2.xxx properties - the url label is not correctly set), #42 (Support X-ABLabel and ITEM2.xxx properties), #732 (Properties fixes), #612 (Delete property), and #5 (Set up transifex).

@skjnldsv
Copy link
Member

Hum, I'm not sure vcards support a default value here.
Type is empty there (pref is irrelevant in that case).

Though it should have at least an info stating none are set, not just an empty space :)

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Mar 29, 2019
@j-ed
Copy link
Author

j-ed commented Mar 29, 2019

I don't know how an entry is exactly parsed but I would assume that SabreDAV allows to set default values for empty fields - but you are the specialist here 😉

@skjnldsv
Copy link
Member

skjnldsv commented Mar 29, 2019

Ah, ok. I get it, this is simple, the URL does not allow custom labels/type! :)
Even on Android I cannot set one (9.0)
Closing this one then 😉

@j-ed
Copy link
Author

j-ed commented Mar 29, 2019

Oh yes, you're right. But shouldn't the default label should be displayed in this case? The following entry e.g. is correctly displayed in another vcard record:

URL;VALUE=URI:http://www.domain.com/

@skjnldsv
Copy link
Member

@j-ed you're right! i'll push a fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants