Add favicons

[st3iny]

Fixes #1947

All SVGs were created and converted to PNGs with Inkscape. The ICO version was converted using ImageMagick. For dimensions and styling I adhered to the favicons of nextcloud/mail.

All PNGs and SVGs were optimized using nextcloud/server/build/image-optimization.sh.

[codecov]

Codecov Report

Merging #1960 (0ef653f) into master (ecb4a05) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1960   +/-   ##
=========================================
  Coverage     67.53%   67.53%           
  Complexity      249      249           
=========================================
  Files            22       22           
  Lines           690      690           
=========================================
  Hits            466      466           
  Misses          224      224           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb4a05...e2369cd. Read the comment docs.

[skjnldsv]

They're supposed to be generated by the server for quite some times now. Thus why they're not here anymore.
I'm confused to what is happening 🤔
cc @juliushaertl, do you know a bit more?

[st3iny]

I checked every app on my private instance and I see favicons only for the apps which explicitly ship their own. Could the auto generation be related to the theming app? I had to disable this app because it is not working well when using a s3 bucket as primary storage.

[juliushaertl]

It requires imagick with svg support being enabled on the instance, maybe that is not the case here then:

https://github.com/nextcloud/server/blob/cb057829f72c70e819f456edfadbb29d72dba832/apps/theming/lib/Controller/IconController.php#L126
https://github.com/nextcloud/server/blob/f5ef2d7d5897bb490f2a10792760f809a68e4c00/apps/theming/lib/ImageManager.php#L299-L303

[skjnldsv]

It requires imagick with svg support being enabled on the instance, maybe that is not the case here then:

I have imagick enabled and definitely don't have the contacts favicon 🤔
I think it's broken?

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-contacts and #nextcloud-dev on Freenode for a chat!

[juliushaertl]

Hm, works for me:

[st3iny]

@juliushaertl @skjnldsv FYI, the theming app is responsible for automatic favicon generation.

I enabled it on my Nextcloud server and all the favicons are getting generated automatically now. The HTML source code reveals the following url for the generated favicon: /apps/theming/favicon/contacts?v=0.

EDIT: typo