Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display name with empty last name when sorting by last name #2040

Merged
merged 1 commit into from Feb 15, 2021

Conversation

NerLOR
Copy link
Contributor

@NerLOR NerLOR commented Feb 5, 2021

When sorting by last name, contacts without last name result in , Alice because last and first name are joined with ', ' regardless of their contents. Easy fix: return only first name if last name is empty.

Signed-off-by: Lorenz Stechauner <lorenz.stechauner@necronda.net>
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #2040 (65e4ac9) into master (89adcae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2040   +/-   ##
========================================
  Coverage      0.00%   0.00%           
  Complexity      249     249           
========================================
  Files            22      22           
  Lines           748     748           
========================================
  Misses          748     748           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89adcae...a481bcf. Read the comment docs.

@NerLOR NerLOR changed the title Fix display name with empty last name when sorting after last name Fix display name with empty last name when sorting by last name Feb 5, 2021
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes more sense! :)
Thanks for the feedback!

@skjnldsv skjnldsv merged commit 6cbd246 into nextcloud:master Feb 15, 2021
@welcome
Copy link

welcome bot commented Feb 15, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-contacts and #nextcloud-dev on Freenode for a chat!

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants