Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple merge delete #2756

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

MrPompom
Copy link
Contributor

commits to add features linked to :#70 (comment) and #277 (comment)

How it works :

When the mouse is over a contact, the avatar changes to a checkbox.
The checkbox can be checked, when only 1 checkbox is selected, the delete button appears, when it's 2 or more it's a menu with the delete and merge button.

image

Delete :

When the delete button is clicked, all the selected contacts are deleted
image

Merge :

When the merge button is clicked, it will merge all the selected contacts into the first selected contact
image

The value except uid, version, fn, prodid, gender, rev will be added into the first selected contact

The value who already exist and default value will not be added
image

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Base: 31.41% // Head: 67.96% // Increases project coverage by +36.54% 🎉

Coverage data is based on head (b6635b5) compared to base (68b15a3).
Patch has no changes to coverable lines.

❗ Current head b6635b5 differs from pull request most recent head e89d9a3. Consider uploading reports for the commit e89d9a3 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2756       +/-   ##
=============================================
+ Coverage     31.41%   67.96%   +36.54%     
  Complexity      253      253               
=============================================
  Files           110       23       -87     
  Lines          1862      721     -1141     
  Branches        217        0      -217     
=============================================
- Hits            585      490       -95     
+ Misses         1162      231      -931     
+ Partials        115        0      -115     
Impacted Files Coverage Δ
src/components/ContactsList.vue
src/components/ContactsList/ContactsListItem.vue
src/services/checks/invalidREV.js
src/mixins/PropertyMixin.js
src/components/Properties/PropertyGroups.vue
src/components/Properties/PropertyDateTime.vue
src/components/MembersList/MembersListItem.vue
src/router/index.js
src/models/rfcProps.js
src/utils/chartUtils.js
... and 77 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MrPompom MrPompom force-pushed the multiple-merge-delete branch 2 times, most recently from eaf43c5 to 396f56c Compare June 2, 2022 08:45
@MrPompom MrPompom mentioned this pull request Jun 2, 2022
@st3iny st3iny added enhancement New feature or request 3. to review Waiting for reviews feature: contacts labels Jun 7, 2022
@szaimen szaimen requested review from st3iny and removed request for st3iny October 4, 2022 23:45
Add checkbox on hover and add a button to delete the selected contacts

Signed-off-by: Bastien PROMPSY <bastienprompsy@gmail.com>
Add a button to merge the selected contacts

Signed-off-by: Bastien PROMPSY <bastienprompsy@gmail.com>
@szaimen
Copy link
Contributor

szaimen commented Oct 11, 2022

I just rebased this. Hopefully I didn't break anything while doing so.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little but important detail missing is handling of address book relations. IMO if all selected contacts belong to the same AB, the merging is OK to do, but across ABs (especially when they are shared) you have to either forbid the operation or ask the user what destination AB they want the merged contact to be written to.

I also don't see any handling of ACLs. It's possible that some ABs are read-only. Then they should probably be ignored for merging as you can neither merge into those contacts nor delete the contact after merging into another AB.

@st3iny st3iny removed enhancement New feature or request 3. to review Waiting for reviews labels Oct 17, 2022
@ChristophWurst ChristophWurst added the 1. to develop Accepted and waiting to be taken care of label Oct 20, 2022
@ChristophWurst
Copy link
Member

@MrPompom please have a look at #2756 (review). Would that be something you could address? Cheers

@ChristophWurst ChristophWurst marked this pull request as draft January 17, 2023 10:57
@melroy89
Copy link

melroy89 commented Feb 16, 2024

I really would like to have multi contact selection for batch deletion, that would be a very very welcome feature. Without the need of installing Thunderbird.

Ps. @MrPompom doesn't seem to be active anymore at all under GitHub. I think it's better to copy his changes and continue in another branch if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of feature: contacts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants