Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed contactsHeader details update #524

Merged
merged 1 commit into from Mar 20, 2018
Merged

Fixed contactsHeader details update #524

merged 1 commit into from Mar 20, 2018

Conversation

skjnldsv
Copy link
Member

Regression by #425

@skjnldsv
Fixed contactsHeader details update
d700947 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews high High priority regression Regression of a previous working feature labels Mar 20, 2018
@skjnldsv skjnldsv added this to the 2.1.2 milestone Mar 20, 2018
@skjnldsv skjnldsv self-assigned this Mar 20, 2018
georgehrke
georgehrke approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works 👍

@skjnldsv skjnldsv merged commit 573a7c8 into master Mar 20, 2018
@skjnldsv skjnldsv deleted the fix-contacts-details-header-update branch March 20, 2018 15:28
@codecov
Copy link

codecov bot commented Mar 20, 2018 •
edited

Codecov Report

Merging #524 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   15.79%   15.77%   -0.03%     
==========================================
  Files          61       61              
  Lines        1380     1382       +2     
==========================================
  Hits          218      218              
- Misses       1162     1164       +2
Impacted Files Coverage Δ
...onents/contactDetails/contactDetails_controller.js 1.88% <0%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ecdd7...d700947. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@georgehrke georgehrke georgehrke approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@Henni Henni Awaiting requested review from Henni

@jonatoni jonatoni Awaiting requested review from jonatoni

@xh3n1 xh3n1 Awaiting requested review from xh3n1

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working high High priority regression Regression of a previous working feature
Projects
None yet
Milestone
2.1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skjnldsv @rullzer @georgehrke