Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property-defined actions and populate FN if unchanged or empty #898

Merged
merged 2 commits into from Jan 30, 2019
Merged

Add property-defined actions and populate FN if unchanged or empty #898

merged 2 commits into from Jan 30, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 30, 2019 •
edited

Fix #821

Action Auto-fill
peek 30-01-2019 12-27 peek 30-01-2019 12-34

@skjnldsv skjnldsv added bug Something isn't working enhancement New feature or request 2. developing Work in progress labels Jan 30, 2019
@skjnldsv skjnldsv added this to the next milestone Jan 30, 2019
@skjnldsv skjnldsv self-assigned this Jan 30, 2019
@codecov

This comment has been minimized.

Sign in to view
@skjnldsv
Add property-defined actions
a1561df 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews design Related to the design and removed 2. developing Work in progress labels Jan 30, 2019
@jancborchardt
Copy link
Member

Nice! Some details:

  • The "Detailed name" header is duplicated? The second one (which is also misaligned) seems not necessary? Then the 3-dot menu can just be on the row of the heading.
  • The "Delete" action should always be the very last in a menu.
  • When you initially use the detailed name to fill, it auto-fills the main name field (second gif). Couldn’t that also happen on change? The "Copy to full name" action seems like unnecessary work for users?

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 30, 2019 •
edited

Hey thanks :)

  1. let's see that in another issue then. I could indeed need some help on this. This design have been like that for ages 🙈
  2. 👍
  3. Well, this was a feature that was requested to be removed a lot on the previous versions. Basically in the vcard you can set the display Name and the detailed name. Those can and need to be completely independant. I can rename my wife Wife 🥰 but still wants to keep the detailed name informations.
    This is why we have an automated step (that use the detailed name to fill the display name in some cases only:
    1. the displayName is not set
    2. the displayName is empty
    3. the displayName is still set to the default New Contact
      BUT if you manually want to have the same you can use the copy action. (or not use a detailed name property at all, this is allowed)

@skjnldsv
Fix string detection, put delete in last and fix properties scoping
41e8ec1 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
jancborchardt
jancborchardt approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good then!

@skjnldsv skjnldsv merged commit 91c02d8 into master Jan 30, 2019
@skjnldsv skjnldsv deleted the populate-FN-if-unchanged branch January 30, 2019 12:09
@skjnldsv skjnldsv modified the milestones: next, 3.0.3 Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design enhancement New feature or request
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skjnldsv @jancborchardt