Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change abort icon during editing #1966

Closed
christianlupus opened this issue Dec 12, 2023 · 1 comment · Fixed by #1971
Closed

Change abort icon during editing #1966

christianlupus opened this issue Dec 12, 2023 · 1 comment · Fixed by #1971
Assignees
@seyfeb
Labels
enhancement New feature or request Frontend Issue or PR related to the frontend code good first issue Good for newcomers javascript Pull requests that update Javascript code

Comments

@christianlupus
Copy link
Collaborator

christianlupus commented Dec 12, 2023 •
edited

The Abort Edit button has an eye as icon

Yes, this is true and was also the case with the older versions. The idea was a to indicate a view-only mode.

Originally posted by @christianlupus in #1950 (comment)

There should be a better icon for aborting the editing of a recipe than the eye.

Depends on #1950
@christianlupus christianlupus added enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code Frontend Issue or PR related to the frontend code labels Dec 12, 2023
@christianlupus christianlupus changed the title > The Abort Edit button has an eye as icon Chnage abort icon during editing Dec 12, 2023
@christianlupus christianlupus changed the title Chnage abort icon during editing Change abort icon during editing Dec 12, 2023
@seyfeb seyfeb self-assigned this Dec 12, 2023
@seyfeb seyfeb mentioned this issue Dec 12, 2023
Merged
4 tasks
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seyfeb seyfeb

Labels
enhancement New feature or request Frontend Issue or PR related to the frontend code good first issue Good for newcomers javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/1966 change abort icon during editing nextcloud/cookbook
2 participants
@seyfeb @christianlupus