Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1966 change abort icon during editing #1971

Merged
merged 3 commits into from Dec 13, 2023

Conversation

seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Dec 12, 2023

Topic and Scope

Replaces eye with close icon in recipe editor for cancelling edit.

Closes #1966

Concerns/issues

Depends on #1950

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Copy link

Test Results

552 tests   552 ✔️  19s ⏱️
143 suites      0 💤
    3 files        0

Results for commit 53f4472.

Copy link

This PR/issue depends on:

Signed-off-by: Sebastian Fey <sebastian@arfinity.io>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Sebastian Fey <sebastian@arfinity.io>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus force-pushed the fix/1966-change-abort-icon-during-editing branch from 53f4472 to afb83e5 Compare December 13, 2023 07:49
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus merged commit bc7b7b7 into master Dec 13, 2023
36 of 37 checks passed
@christianlupus christianlupus deleted the fix/1966-change-abort-icon-during-editing branch December 13, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change abort icon during editing
2 participants