Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1297 import recipe with howto steps #1300

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

christianlupus
Copy link
Collaborator

Closes #1297

This is mainly the backend part of the issue #1297. The frontend should be done with the major rework of the UI in #1244.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1300 (2ba0880) into master (effbcb5) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
+ Coverage   78.75%   78.88%   +0.13%     
==========================================
  Files          86       86              
  Lines        2273     2288      +15     
==========================================
+ Hits         1790     1805      +15     
  Misses        483      483              
Flag Coverage Δ
integration 21.41% <0.00%> (-0.15%) ⬇️
migration 4.06% <0.00%> (-0.03%) ⬇️
unittests 57.69% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Helper/Filter/JSON/FixInstructionsFilter.php 100.00% <100.00%> (ø)

@christianlupus
Copy link
Collaborator Author

Currently, the UI looks a bit odd as the number are continuing to count:
grafik

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@github-actions
Copy link

github-actions bot commented Oct 31, 2022

Test Results

     15 files     680 suites   3m 41s ⏱️
   495 tests    495 ✔️ 0 💤 0
2 475 runs  2 475 ✔️ 0 💤 0

Results for commit 2ba0880.

♻️ This comment has been updated with latest results.

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus merged commit ed93000 into master Oct 31, 2022
@christianlupus christianlupus deleted the fix/1297-import-recipe-with-howto-steps branch October 31, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error parsing recipe: Cannot parse recipe: Unknown object found during flattening of instructions.
2 participants