Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix, also to prevent escaping issues #1582

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Typo fix, also to prevent escaping issues #1582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c3cf07
Typo fix, also to prevent escaping issues
roliverio Mar 27, 2023
8831010
Update CHANGELOG.md
christianlupus Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## [Unreleased]

### Fixed
- Fix translation string to not contain quotes
[#1582](https://github.com/nextcloud/cookbook/pull/1582) @roliverio

## 0.10.2 - 2023-03-24

Expand Down
2 changes: 1 addition & 1 deletion src/components/SettingsDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@
// eslint-disable-next-line no-console
console.error("Error while trying to save info blocks", err)
await showSimpleAlertModal(
t("cookbook", "Couldn't save visible info blocks")
t("cookbook", "Could not save visible info blocks")
)
this.resetVisibleInfoBlocks = true
this.visibleInfoBlocks = oldVal
Expand Down Expand Up @@ -399,7 +399,7 @@
</script>

<style scoped>
/* TODO: Use @nextcloud/vue LoadingIcon once we update to 7.0.0 and we won't

Check warning on line 402 in src/components/SettingsDialog.vue

View workflow job for this annotation

GitHub Actions / Check for added todo messages 

Found TODO: Use @nextcloud/vue LoadingIcon once we update to 7.0.0 and we won't
* have to do this */
.material-design-icon.loading-icon:deep(svg) {
animation: rotate var(--animation-duration, 0.8s) linear infinite;
Expand Down