Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in JS console #1686

Merged
merged 2 commits into from May 19, 2023
Merged

Fix bug in JS console #1686

merged 2 commits into from May 19, 2023

Conversation

christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented May 19, 2023

Topic and Scope

For error in console of browser about no defined function isSmaeBaseRoute.

Concerns/issues

No problems with normal functionality

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1686 (5b8d7a9) into master (133a452) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1686   +/-   ##
=======================================
  Coverage   79.41%   79.41%           
=======================================
  Files          87       87           
  Lines        2550     2550           
=======================================
  Hits         2025     2025           
  Misses        525      525           
Flag Coverage Δ
integration 21.21% <ø> (ø)
migration 5.92% <ø> (ø)
unittests 56.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit 87fd30d into master May 19, 2023
35 checks passed
@christianlupus christianlupus deleted the maintenance/no-route-debugs branch May 19, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants