Maintenance/psalm #1691
Merged
Maintenance/psalm #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1691 +/- ##
=======================================
Coverage 79.41% 79.41%
=======================================
Files 87 87
Lines 2550 2550
=======================================
Hits 2025 2025
Misses 525 525
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
christianlupus
force-pushed
the
maintenance/psalm
branch
from
5a28a5a
to
60167f3
Compare
|
/approve |
nextcloud-cookbook-bot
approved these changes
May 29, 2023
Signed-off-by: Christian Wolf <github@christianwolf.email>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic and Scope
This PR should enable the static code checker psalm on the code base.
Closes #990
Concerns/issues
The current baseline is the state of the code style. So, there are quite some errors hidden from the user currently. These need to be addressed at some point.
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.