Revert "Removed obsolete parameters from OpenAPI specs" #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a follow-up of #1544. |
|
/approve |
nextcloud-cookbook-bot
approved these changes
May 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1700 +/- ##
=======================================
Coverage 79.41% 79.41%
=======================================
Files 87 87
Lines 2550 2550
=======================================
Hits 2025 2025
Misses 525 525
Flags with carried forward coverage won't be shown. Click here to find out more. |
This reverts commit 07954bf. The @type annotation should be still part of the OpenAPI description. Although the returned JSON objects are considered compatible with the schema.org standard, this does not mean, we should not make the implications explicit. Also, this makes reading more clean and avoid misunderstandings regarding if the @type is to be present or not. Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
christianlupus
force-pushed
the
revert/openapi-without-type
branch
from
fa732d3
to
219e3a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic and Scope
This reverts commit 07954bf.
The
@typeannotation should be still part of the OpenAPI description. Although the returned JSON objects are considered compatible with the schema.org standard, this does not mean, we should not make the implications explicit. Also, this makes reading more clean and avoid misunderstandings regarding if the@typeis to be present or not.Concerns/issues
Just documentation, no effects
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.