Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance recipe recalculation algorithm #1723

Merged
merged 7 commits into from Jun 30, 2023
Merged

Enhance recipe recalculation algorithm #1723

merged 7 commits into from Jun 30, 2023

Conversation

j0hannesr0th
Copy link
Contributor

@j0hannesr0th j0hannesr0th commented Jun 11, 2023 •
edited by christianlupus

Topic and Scope

Fixes at least partially #1603

See it live:

Screencast.from.11.06.2023.23.44.37.webm

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@j0hannesr0th
Enhance recipe recalculation algorithm
d73737e 
Signed-off-by: Johannes Roth <git@jrcloud.de>
@j0hannesr0th
Enhance recipe recalculation algorithm
2b12803 
Signed-off-by: Johannes Roth <git@jrcloud.de>
@j0hannesr0th j0hannesr0th mentioned this pull request Jun 11, 2023
Closed
6 tasks
@github-actions
Copy link

github-actions bot commented Jun 11, 2023 •
edited

Test Results

     27 files  1 233 suites   6m 45s ⏱️
   498 tests    498 ✔️ 0 💤 0 ❌
4 482 runs  4 481 ✔️ 1 💤 0 ❌

Results for commit 45166e0.

♻️ This comment has been updated with latest results.

j0hannesr0th and others added 2 commits June 11, 2023 23:50
@j0hannesr0th
Merge branch 'nextcloud:master' into master
a16ee89
@j0hannesr0th
Update changelog
d21260f 
Signed-off-by: Johannes Roth <git@jrcloud.de>
@j0hannesr0th j0hannesr0th mentioned this pull request Jun 13, 2023
Open
@christianlupus
Move new code to separate module and interlink correctly
4511252 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Fix code styling
45166e0 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Final comment and removed duplicte code
d3feaec 
Signed-off-by: Christian Wolf <github@christianwolf.email>
christianlupus
christianlupus approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some flaws still in the code but this is yet much better than before.

I unlinked the underlying issue as it is not yet fully satisfied.

@christianlupus christianlupus merged commit 838080d into nextcloud:master Jun 30, 2023
20 checks passed
@christianlupus christianlupus added this to the Release 0.10.3 milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianlupus christianlupus christianlupus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.10.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j0hannesr0th @christianlupus