Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade docs to docker compose v2 #1772

Merged
merged 4 commits into from Aug 29, 2023

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented Jul 30, 2023

Topic and Scope

Upgrades instructions and the local test runner to use Docker Compose v2 instead of Docker Compose.

Docker Compose v2 has been out for some time, and Docker Compose v1 (docker-compose) no longer receives updates.

From July 2023 Compose V1 stopped receiving updates. It’s also no longer available in new releases of Docker Desktop.

https://docs.docker.com/compose/

I think it makes sense to push the documentation and commands over to the v2 equivalents now, since this is what most engineers should have installed now.

Concerns/issues

I have only tested this locally. I'm not sure if this will work as-is on CI or if more needs to be done.

It's also worth considering if a significant portion of maintainers/contributors cannot upgrade to Docker Compose v2 for some reason? 🤔 (I can't think of one, but I'm just wary as I don't know why this repository was still using docker-compose instead of docker compose.)

A similar proposal was made for nextcloud-docker-dev, which looks like it will be merged soon too:

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Seth Falco <seth@falco.fun>
@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Test Results

     27 files  1 233 suites   7m 9s ⏱️
   498 tests    498 ✔️ 0 💤 0
4 482 runs  4 481 ✔️ 1 💤 0

Results for commit 8b6bdd0.

♻️ This comment has been updated with latest results.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus merged commit eb896b3 into nextcloud:master Aug 29, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants