Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped old polyfill code #1843

Merged
merged 2 commits into from Oct 12, 2023
Merged

Conversation

christianlupus
Copy link
Collaborator

Topic and Scope

This is a maintenance to remove an old polyfill code for NC20.

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Copy link
Collaborator Author

/approve

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus linked an issue Oct 12, 2023 that may be closed by this pull request
@christianlupus christianlupus added this to the Release 0.10.3 milestone Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1843 (b4d935b) into master (4920340) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1843      +/-   ##
==========================================
- Coverage   79.67%   79.54%   -0.13%     
==========================================
  Files          89       89              
  Lines        2573     2577       +4     
==========================================
  Hits         2050     2050              
- Misses        523      527       +4     
Flag Coverage Δ
integration 21.84% <0.00%> (-0.04%) ⬇️
migration 5.85% <0.00%> (-0.01%) ⬇️
unittests 55.91% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/Search/Provider.php 0.00% <0.00%> (ø)

@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit 2ec2345 into master Oct 12, 2023
33 checks passed
@christianlupus christianlupus deleted the maintenance/remove-dead-search-code branch October 12, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop legacy code
2 participants