Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load config explicitly and remove setup routine of settings component #1892

Merged
merged 6 commits into from Nov 20, 2023

Conversation

christianlupus
Copy link
Collaborator

Topic and Scope

This is a first step to prevent regular updating of the config on each page reload.

Closes #1752

Concerns/issues

The PR just covers the basic changes. The migration to the InitialState is not yet carried out.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus added this to the Release 0.10.3 milestone Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #1892 (c31af11) into master (9bbeb0c) will not change coverage.
Report is 11 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1892   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files          89       89           
  Lines        2582     2582           
=======================================
  Hits         2054     2054           
  Misses        528      528           
Flag Coverage Δ
integration 21.99% <ø> (ø)
migration 5.84% <ø> (ø)
unittests 55.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Copy link

Test Results

     27 files  1 242 suites   5m 45s ⏱️
   510 tests    510 ✔️ 0 💤 0
4 590 runs  4 589 ✔️ 1 💤 0

Results for commit 185fb32.

Copy link
Collaborator

@seyfeb seyfeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the two minor points it looks fine to me.

src/components/SettingsDialog.vue Show resolved Hide resolved
src/components/SettingsDialog.vue Show resolved Hide resolved
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
@seyfeb seyfeb merged commit cfc2b86 into master Nov 20, 2023
46 checks passed
@seyfeb seyfeb deleted the fix/1752-extract-config-loading branch November 20, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration is stored upon each page visit
2 participants