Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1590 recipe id in stubs #1909

Merged
merged 5 commits into from Dec 3, 2023
Merged

Conversation

christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented Dec 3, 2023

Topic and Scope

This should provide a unique interface by adding a string entry id both to the stubs and to the full recipes.

Closes #1590

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus added this to the Release 0.10.3 milestone Dec 3, 2023
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Merging #1909 (95840ba) into master (8a21d46) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1909      +/-   ##
==========================================
+ Coverage   79.55%   79.57%   +0.02%     
==========================================
  Files          89       89              
  Lines        2582     2585       +3     
==========================================
+ Hits         2054     2057       +3     
  Misses        528      528              
Flag Coverage Δ
integration 21.97% <0.00%> (-0.03%) ⬇️
migration 5.84% <0.00%> (-0.01%) ⬇️
unittests 56.01% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Controller/Implementation/RecipeImplementation.php 100.00% <100.00%> (ø)
lib/Helper/Filter/DB/NormalizeRecipeFileFilter.php 100.00% <100.00%> (ø)
lib/Helper/Filter/DB/RecipeDatesFilter.php 100.00% <ø> (ø)
lib/Helper/Filter/JSON/AbstractJSONFilter.php 100.00% <ø> (ø)
lib/Helper/Filter/JSON/CleanCategoryFilter.php 100.00% <ø> (ø)
lib/Helper/Filter/JSON/ExtractImageUrlFilter.php 100.00% <ø> (ø)
lib/Helper/Filter/JSON/FixDescriptionFilter.php 100.00% <ø> (ø)
lib/Helper/Filter/JSON/FixDurationsFilter.php 100.00% <ø> (ø)
lib/Helper/Filter/JSON/FixImageSchemeFilter.php 100.00% <ø> (ø)
lib/Helper/Filter/JSON/FixIngredientsFilter.php 100.00% <ø> (ø)
... and 16 more

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit 7156443 into master Dec 3, 2023
35 checks passed
@christianlupus christianlupus deleted the fix/1590-recipe-id-in-stubs branch December 3, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong json returned from the api
2 participants