Fix/1962 error when changing rescan period #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Attention, this is based on the other PR #1950. So, do not merge yet but first handle the other PR. |
|
This PR/issue depends on:
|
christianlupus
force-pushed
the
fix/1962-error-when-changing-rescan-period
branch
from
e56d385
to
8e703cb
Compare
Signed-off-by: Sebastian Fey <sebastian@arfinity.io> Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
christianlupus
force-pushed
the
fix/1962-error-when-changing-rescan-period
branch
from
8e703cb
to
e6c9a9d
Compare
christianlupus
approved these changes
Dec 13, 2023
christianlupus
deleted the
fix/1962-error-when-changing-rescan-period
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic and Scope
Fixes the error message shown when the update interval field in the settings window is empty.
Concerns/issues
Unfocusing the field does not show a warning, however then the value simply remains unchanged. In the future general form validation capabilities might be helpful (for the settings but also recipe editing), but afaik not supported by Nextcloud vue component by the time of writing.
Closes #1962
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.
Depends on #1950