Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent yield calculation for ## as ingredient headline #1998

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

j0hannesr0th
Copy link
Contributor

Topic and Scope

fixes #1985

2023-12-15_130713.mp4

Concerns/issues

none.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Johannes Roth <git@jrcloud.de>
Signed-off-by: Johannes Roth <git@jrcloud.de>
Copy link

Test Results

     12 files     572 suites   1m 31s ⏱️
   552 tests    552 ✔️ 0 💤 0
2 208 runs  2 207 ✔️ 1 💤 0

Results for commit 8d4a606.

Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christianlupus christianlupus merged commit 170edf7 into nextcloud:master Dec 15, 2023
18 checks passed
@christianlupus christianlupus added the manual-backport-required The backpoort needs to be carried out manually. label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manual-backport-required The backpoort needs to be carried out manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent ingredient warning for headings
2 participants