fix: ingredients showing NaN in some cases #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 12 files 572 suites 1m 29s ⏱️ Results for commit def3b76. ♻️ This comment has been updated with latest results. |
Signed-off-by: Johannes Roth <git@jrcloud.de>
Signed-off-by: Johannes Roth <git@jrcloud.de> Signed-off-by: Christian Wolf <github@christianwolf.email>
|
This PR will not fix the issue #1986. Thus, I removed the lined dependency to avoid closing it unintentionally. Nevertheless this fixes a bug and should be merged anyways. |
christianlupus
approved these changes
Jan 7, 2024
christianlupus
added
the
manual-backport-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic and Scope
2023-12-17_104620.mp4
Concerns/issues
none.
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.