Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yield not set calculation error #2099

Merged
merged 3 commits into from
Jan 27, 2024

Conversation

j0hannesr0th
Copy link
Contributor

@j0hannesr0th j0hannesr0th commented Jan 26, 2024

Fixes #1986

Thanks for the video @christianlupus - I haven't knew that I can click "servings" to disable them. When trying to reproduce it I just haven't set it and it was "1" by default.

image

Please write, what the PR is about and what it does or should do. This does not need to be very long.

none.

Is the PR potentially cause any issues that might be of interest? Any other issues to be tought of?

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Copy link

github-actions bot commented Jan 26, 2024

Test Results

   12 files    572 suites   1m 30s ⏱️
  552 tests   552 ✅ 0 💤 0 ❌
2 208 runs  2 207 ✅ 1 💤 0 ❌

Results for commit 407491d.

♻️ This comment has been updated with latest results.

Signed-off-by: Johannes Roth <git@jrcloud.de>
Signed-off-by: Johannes Roth <git@jrcloud.de>
Signed-off-by: Johannes Roth <git@jrcloud.de>
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christianlupus christianlupus merged commit 3ab99d6 into nextcloud:master Jan 27, 2024
19 checks passed
@christianlupus christianlupus added the manual-backport-required The backpoort needs to be carried out manually. label Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manual-backport-required The backpoort needs to be carried out manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent recalculation algorithm if no yeild is given
2 participants