Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing Options #627

Closed
wants to merge 48 commits into from
Closed

Sharing Options #627

wants to merge 48 commits into from

Conversation

matrois
Copy link

@matrois matrois commented Mar 2, 2021

Sharing options would be handy. At its best one for recipe and one for category (i.e. to allow public access on whole categories)

christianlupus and others added 30 commits February 15, 2021 12:48
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Added translatable placeholder for nutritient selection
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Deprecate some routes by comments
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
The current implementation to detect translation strings uses a
one-line regex. So we must keep all translations on one line.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Usage of prettier in order to have a clear coding standard
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Enable stylelint to keep CSS codes clean and tight
nextcloud-bot and others added 18 commits February 24, 2021 02:31
Some minor bugfixes

Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Signed-off-by: Sebastian Fey <info@sebastianfey.de>
Eslint, Code cleanup, some bugfixes
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Disable testing in repos without secrets
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Do not only filter but exclude paths from search
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #627 (8ec449f) into stable (052b883) will increase coverage by 0.13%.
The diff coverage is 5.12%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable    #627      +/-   ##
===========================================
+ Coverage      0.87%   1.01%   +0.13%     
- Complexity      436     444       +8     
===========================================
  Files            14      14              
  Lines          1375    1385      +10     
===========================================
+ Hits             12      14       +2     
- Misses         1363    1371       +8     
Flag Coverage Δ Complexity Δ
integration 0.00% <0.00%> (ø) 0.00 <7.00> (ø)
unittests 1.01% <5.12%> (+0.13%) 0.00 <7.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/Controller/ConfigController.php 0.00% <0.00%> (ø) 7.00 <0.00> (ø)
lib/Controller/MainController.php 0.00% <0.00%> (ø) 40.00 <6.00> (+7.00)
lib/Db/RecipeDb.php 0.00% <0.00%> (ø) 57.00 <0.00> (ø)
lib/Exception/UserFolderNotWritableException.php 0.00% <0.00%> (ø) 1.00 <1.00> (?)
lib/Helper/RestParameterParser.php 0.00% <0.00%> (ø) 20.00 <0.00> (ø)
lib/Service/RecipeService.php 0.00% <0.00%> (ø) 239.00 <0.00> (+2.00)
lib/Service/JsonService.php 100.00% <100.00%> (ø) 9.00 <0.00> (+2.00)

@seyfeb
Copy link
Collaborator

seyfeb commented Mar 2, 2021

You probably meant to open an issue instead of a pull request. There are already two issues discussing sharing, see #120 #392 You can comment on those if you’d like to contribute ideas.

@seyfeb seyfeb closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants