Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.0-alpha1: possible to add cards when in archive view #1682

Closed
cloud2018 opened this issue Apr 11, 2020 · 0 comments · Fixed by #1707, #1708 or #1730
Closed

1.0.0-alpha1: possible to add cards when in archive view #1682

cloud2018 opened this issue Apr 11, 2020 · 0 comments · Fixed by #1707, #1708 or #1730
Assignees
@jakobroehrl
Labels
1. to develop bug: regression

Comments

@cloud2018
Copy link
Contributor

Describe the bug
It's possible to add cards when showing only archieved cards

To Reproduce
Steps to reproduce the behavior:

  1. Open a board
  2. Click on "show archived cards"
  3. Click on "+" to add card
  4. Error: it's possible to add card

Expected behavior

  1. Like in previous version of deck, there should be no "+" icon to add a card, when only archived cards are shown
  2. Like in previous version of deck, there should be "Archived cards" right of the boards name

Screenshots
alpha version:
d4_2

previous version:
d4_1
@jakobroehrl jakobroehrl self-assigned this Apr 15, 2020
@jakobroehrl jakobroehrl mentioned this issue Apr 16, 2020
Merged
@ishantgupta777 ishantgupta777 mentioned this issue Apr 17, 2020
Merged
ishantgupta777 added a commit to ishantgupta777/deck that referenced this issue Apr 17, 2020
@ishantgupta777
fixed cards getting added in archive view and closes nextcloud#1682
478f849 
Signed-off-by: Ishant <ishantgupta777@gmail.com>
juliushaertl added a commit that referenced this issue Apr 17, 2020
@juliushaertl
Merge pull request #1708 from ishantgupta777/fixed_cards_in_archive_view
742d138 
fixed cards getting added in archive view and closes #1682
@juliushaertl juliushaertl mentioned this issue Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakobroehrl jakobroehrl

Labels
1. to develop bug: regression
Projects
None yet
Milestone
No milestone
3 participants
@juliushaertl @jakobroehrl @cloud2018