Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upcoming/Today/Tomorrow dashboard widgets #2658

Merged
merged 6 commits into from Oct 18, 2023
Merged

Upcoming/Today/Tomorrow dashboard widgets #2658

merged 6 commits into from Oct 18, 2023

Conversation

BKapelari
Copy link
Contributor

@BKapelari BKapelari commented Dec 16, 2020 •
edited

Summary

Basic function for the new dashboard widgets

TODO

  • Translations

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

juliushaertl
juliushaertl reviewed Dec 16, 2020
View reviewed changes
l10n/de_DE.js Outdated Show resolved Hide resolved
juliushaertl
juliushaertl reviewed Dec 17, 2020
View reviewed changes
src/views/DashboardToday.vue
return generateUrl('/apps/deck') + `#/board/${card.boardId}/card/${card.id}`
}
},
showMoreUrl() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those could go into a mixin to avoid duplicate code across widgets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still open

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's how you create a mixin: https://v2.vuejs.org/v2/guide/mixins.html

Let me know if you need help :)

@BKapelari
Copy link
Contributor Author

BKapelari commented Dec 17, 2020 •
edited

Idea: Should we rename src/views/Dashboard.vue to something else?

@juliushaertl
Copy link
Member

Idea: Should we rename src/views/Dashboard.vue to something else?

Yes, since this PR introduces DashboardToday and DashboardTomorrow, it could just be DashboardUpcoming for example.

@BKapelari
Copy link
Contributor Author

@juliushaertl please take a look.

@BKapelari
Copy link
Contributor Author

@juliushaertl do you think, we can let this on this status an merge it into main?
If you see any problems, let me know, I will try to resolve them

@juliushaertl juliushaertl added this to the 1.3.0 milestone Jan 28, 2021
@juliushaertl
Copy link
Member

Sorry for the delay here, I have it on my list of things to review.

@BKapelari
Copy link
Contributor Author

BKapelari commented Feb 8, 2021 •
edited

can we merge? Are only a few changes: https://github.com/nextcloud/deck/pull/2658/files

@juliushaertl juliushaertl modified the milestones: 1.3.0, 1.4.0, 1.5.0, 2.0.0 Apr 7, 2021
@jakobroehrl
Copy link
Contributor

@BKapelari could you provide some screenshots?

@juliushaertl juliushaertl modified the milestones: 1.5.0, 1.6.0 Nov 5, 2021
@juliushaertl juliushaertl modified the milestones: 1.6.0, 1.7.0 Dec 30, 2021
@juliushaertl juliushaertl changed the title basic functions Upcoming/Today/Tomorrow dashboard widgets Aug 9, 2022
@marcelklehr
Copy link
Member

I gave this some love and resolved all open issues. Should be good to go now.

image

@juliushaertl juliushaertl self-requested a review January 6, 2023 18:05
BKapelari and others added 4 commits October 18, 2023 11:44
@BKapelari @juliushaertl
basic functions
7b57c92 
Signed-off-by: Bernhard Kapelari <bernhard@kapelari.com>

First feedback

Signed-off-by: Bernhard Kapelari <bernhard@kapelari.com>

lint:fix

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr @juliushaertl
Dashboard widgets: Factor out a card component
515d9cb 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr @juliushaertl
Vuex: Run overview#loadUpcoming only once
a37e719 
needed for dashboard widgets

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr @juliushaertl
Rename today and tomorrow widgets
6aaa9be 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@juliushaertl
Copy link
Member

Did another rebase and resolved conflicts

@juliushaertl
fix: Switch to new component name
0b68948 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
style: Fix stylelint
7c774bd 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit ea67956 into nextcloud:main Oct 18, 2023
24 checks passed
@marcelklehr
Copy link
Member

🎉

@BKapelari BKapelari deleted the More-Dashboard-Widgets-#2643 branch October 18, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr left review comments

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees
No one assigned
Labels
4. to release enhancement
Projects
📝 Office team
Archived in project
Milestone
1.10.0 (Nextcloud 27)
Development

Successfully merging this pull request may close these issues.

More Dashboard Widgets
4 participants
@BKapelari @juliushaertl @jakobroehrl @marcelklehr