Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(API): Fix board API details parameter to work as expected #4518

Merged
merged 1 commit into from Mar 8, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 8, 2023

Summary

Before ?details=true in the URL resulted in string "true" and therefore did not match $details === true which was brought in by b19b779 but it matched the old $details logic.

Defining the parameter as bool (like it was done in the other touched controller methods) gives the actual boolean to the controller fixing the comparison

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/4517/fix-board-api-details branch from f1eb361 to 83bc2c5 Compare March 8, 2023 06:38
@nickvergessen
Copy link
Member Author

/backport to stable26

@nickvergessen
Copy link
Member Author

Also applied it on our instance as a patch and the Android app works again :)

@juliushaertl juliushaertl merged commit fc183f6 into main Mar 8, 2023
21 checks passed
@juliushaertl juliushaertl deleted the bugfix/4517/fix-board-api-details branch March 8, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api/v1.0/boards?details=true does not return the labels and stacks anymore, breaking the Android app
3 participants