Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent tag itself being edit button if user lacks permissions #4574

Merged
merged 1 commit into from Apr 4, 2023

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Mar 31, 2023

Summary

The tag itself is also a button for triggering edit mode. It should not be if user permissions don't permit editing. The current behavior lets the user attempt the edit (which then understandably fails - albeit without any feedback to the user since it was likely never expected to occur). This change prevents the button from being clickable to trigger edit mode unless the user has the correct permissions. Modeled after the adjacent checks that already exist which remove the edit and delete buttons for users with permissions. I believe this simply implements what was intended and the label/tag itself also being able to trigger editing was just a minor oversight.

TODO

  • Get reviewed

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • [na] Tests (unit, integration, api and/or acceptance) are included
  • [na] Documentation (manuals or wiki) has been updated or is not required

Addresses nextcloud#4554 

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@juliushaertl juliushaertl merged commit f82297f into nextcloud:main Apr 4, 2023
12 checks passed
@juliushaertl
Copy link
Member

/backport to stable27

@juliushaertl
Copy link
Member

/backport to stable26

@juliushaertl
Copy link
Member

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing Tag fails if not board owner
2 participants