Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better display of card dates (creation and change dates) #4604

Merged
merged 2 commits into from Apr 25, 2023

Conversation

Jerome-Herbinet
Copy link
Member

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

Before :

2023-04-20_10-10

After (inverted + strong and space before ":") :

2023-04-20_10-09

Note : 2 lines are inverted in tooltip as well ... so the "created" line is now above.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@juliushaertl
Copy link
Member

I personally don't like the line break, since we have plenty of space there, but requesting some input from our designers :)

@nimishavijay
Copy link
Member

Great point! It could definitely have better separation!

We use the middle dot symbol (⸱) as a separator in many instances, that could be more fitting here :) That way we can also remove the colon and bolding so that it reads more naturally, like this:

Modified 2 days ago ⸱ Created 1 month ago

What do you think?

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet
Copy link
Member Author

Great point! It could definitely have better separation!

We use the middle dot symbol (⸱) as a separator in many instances, that could be more fitting here :) That way we can also remove the colon and bolding so that it reads more naturally, like this:

Modified 2 days ago ⸱ Created 1 month ago

What do you think?

Done @nimishavijay
Cc @juliushaertl

@juliushaertl juliushaertl merged commit bd9538d into main Apr 25, 2023
14 checks passed
@juliushaertl juliushaertl deleted the Jerome-Herbinet-card-date-patch-1 branch April 25, 2023 08:13
@juliushaertl
Copy link
Member

/backport to stable26

@juliushaertl
Copy link
Member

/backport to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants