Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate endtag and fix layout in safari #51

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Conversation

juliushaertl
Copy link
Member

This PR should fix the missing sidebar in Safari.

@ntinti @emresaracoglu @joergmschulz
It would be great if someone of you could verify that it now works.

@codecov
Copy link

codecov bot commented Feb 14, 2017

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          29       29           
  Lines         739      739           
=======================================
  Hits          596      596           
  Misses        143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5feeea...3a31119. Read the comment docs.

@joergmschulz
Copy link

joergmschulz commented Feb 14, 2017

looks good in my Safari!
looks good in Chrome!

Did somebody check the other browsers out there, IE, Edge, Firefox?

Suggest you merge this one.

@juliushaertl juliushaertl merged commit cb5cfe1 into master Feb 15, 2017
@juliushaertl juliushaertl deleted the safari-fix branch February 15, 2017 06:44
@ntinti
Copy link

ntinti commented Feb 15, 2017

Works like a charm with master from today ,15.02.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants