Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add attributes aria-label= and title= to Filters & View Modes buttons #5133

Merged
merged 2 commits into from Oct 16, 2023
Merged

add attributes aria-label= and title= to Filters & View Modes buttons #5133

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab186a
add attributes aria-label= and title= to Filters & View Modes buttons
privatemaker Sep 19, 2023
1564da5
Update src/components/Controls.vue
juliushaertl Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/Controls.vue
View file
Open in desktop
Expand Up @@ -78,6 +78,8 @@
<NcPopover container=".board-action-buttons__filter"
:placement="'bottom-end'"
:aria-label="t('deck', 'Active filters')"
:title="t('deck', 'Active filters')"
:tooltip="t('deck', 'Active filters')"
@show="filterVisible=true"
@hide="filterVisible=false">
<!-- We cannot use NcActions here are the popover trigger does not update on reactive icons -->
Expand Down Expand Up @@ -188,7 +190,9 @@
</NcPopover>
</div>

<NcActions>
<NcActions
:aria-label="t('deck', 'View Modes')"

Check failure on line 194 in src/components/Controls.vue

View workflow job for this annotation

GitHub Actions / eslint 

Expected no linebreak before this attribute
juliushaertl marked this conversation as resolved.
Show resolved Hide resolved
:title="t('deck', 'Toggle View Modes')">
<NcActionButton @click="toggleShowArchived">
<template #icon>
<ArchiveIcon :size="20" decorative />
Expand Down