feat(card): tooltip for comment timestamp #5253
Conversation
src/components/card/CommentItem.vue
Outdated
| @@ -158,6 +161,9 @@ export default { | |||
| return (div.textContent || div.innerText || '') | |||
| } | |||
| }, | |||
| formattedTimestamp() { | |||
| return moment(this.comment.creationDateTime).format('LLLL') | |||
There was a problem hiding this comment.
| return moment(this.comment.creationDateTime).format('LLLL') | |
| return t('deck', 'Created:') + ' ' + moment(this.comment.creationDateTime).format('LLLL') |
src/components/card/CommentItem.vue
Outdated
| <div class="timestamp"> | ||
| <div class="timestamp" | ||
| :aria-label="formattedTimestamp" | ||
| :title="'Created: ' + formattedTimestamp"> |
There was a problem hiding this comment.
| :title="'Created: ' + formattedTimestamp"> | |
| :title="formattedTimestamp"> |
Combined with the below suggestion to have a translated Created string
|
Hi @juliushaertl, thank you for reviewing my PR. Please kindly wait for the updates. |
Signed-off-by: Fitrah Munir <fitrahmunir@outlook.com>
fitrahmunir
force-pushed
the
feat/tooltip-for-comment-timestamp
branch
from
fdeff64
to
2f16239
Compare
|
Thanks a lot for your contribution 🥳 |
|
You're welcome 🙌 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
Added tooltip for comment timestamp with formatted datetime
TODO
Checklist