scroll board by dragging #5293
Merged
scroll board by dragging #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cypress is green, so i'm marking this as ready for review. |
shoetten
force-pushed
the
feature/scroll-by-dragging
branch
from
9c22a68
to
2ff47e3
Compare
There was a problem hiding this comment.
Hi @shoetten. Thanks a lot for your contribution, this is very much appreciated.
I just left some small comments inline, otherwise this is a great change, happy to merge once clarified. Having the code within the Board component is totally fine with me.
Signed-off-by: Simon Hötten <s+git@hoetten.org>
shoetten
force-pushed
the
feature/scroll-by-dragging
branch
from
2ff47e3
to
d17498b
Compare
juliushaertl
approved these changes
Nov 16, 2023
|
Thanks for the quick adjustment 🥳 |
|
Thanks for the fast review 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivated by the recent uptake of activity in this repo i decided to finally tackle this issue. The PR adds horizontal scrolling of boards by dragging without adding another dependency.
If you wan't the logic out of the board component, i can refactor. I felt like the change was small enough to keep it in there, but feel free to criticize ;)
TODO
Checklist